Skip to content

[sonic-sairedis] Upgrade to c++17 #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Junchao-Mellanox wants to merge 7 commits into from
Closed

[sonic-sairedis] Upgrade to c++17 #1069

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1a23223
[sonic-sairedis] Upgrade to c++17
Junchao-Mellanox Jun 21, 2022
c614caf
Merge branch 'Azure:master' into upgrade-cpp17
Junchao-Mellanox Jun 27, 2022
cb8f8ed
Change azure pipeline image from buster to bullseye
Junchao-Mellanox Jul 1, 2022
7b64dac
Fix issue: swig3.0 cannot be found on bullseye
Junchao-Mellanox Jul 1, 2022
180db78
Disable python2 extension build on bullseye
Junchao-Mellanox Jul 1, 2022
9cf2f2a
Fix issue: change apt repo to debian 11
Junchao-Mellanox Jul 1, 2022
edaebf8
Fix issue: dependencies are all built with buster, hardcode buster he…
Junchao-Mellanox Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ AC_PATH_PROGS(SWIG, [swig3.0 swig])
CXXFLAGS_COMMON=""
CXXFLAGS_COMMON+=" -ansi"
CXXFLAGS_COMMON+=" -fPIC"
CXXFLAGS_COMMON+=" -std=c++14"
CXXFLAGS_COMMON+=" -std=c++17"
CXXFLAGS_COMMON+=" -Wall"
CXXFLAGS_COMMON+=" -Wcast-align"
CXXFLAGS_COMMON+=" -Wcast-qual"
Expand Down Expand Up @@ -157,6 +157,7 @@ CXXFLAGS_COMMON+=" -Wwrite-strings"
CXXFLAGS_COMMON+=" -Wno-switch-default"
CXXFLAGS_COMMON+=" -Wconversion"
CXXFLAGS_COMMON+=" -Wno-psabi"
CXXFLAGS_COMMON+=" -Wno-register"
Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this? I search codebase and did not find register storage class specifier.
ref: https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#index-Wno-register


SAVED_FLAGS="$CXXFLAGS"
CXXFLAGS="-Wcast-align=strict"
Expand Down