Skip to content

Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute#1016

Merged
kcudnik merged 4 commits intosonic-net:202012from
tbgowda:202012.fast-reboot
May 13, 2022
Merged

Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute#1016
kcudnik merged 4 commits intosonic-net:202012from
tbgowda:202012.fast-reboot

Conversation

@tbgowda
Copy link
Copy Markdown
Contributor

@tbgowda tbgowda commented Mar 8, 2022

Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability

  • Remove Mellanox specific checks
  • Check whether the attribute is supported
  • Call SAI API if it is supported, else ignore

Cherry-picking #975

tbgowda added 3 commits March 8, 2022 14:27
Pass fast reboot option to syncd so that SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL gets triggered
Enable SAI_SWITCH_ATTR_UNINIT_DATA_PLANE_ON_REMOVAL attribute for all platforms based on capability
Remove Mellanox specific checks
Check whether the attribute is supported
Call SAI API if it is supported, else ignore
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Mar 9, 2022

how is this tested on all platforms?

@tbgowda
Copy link
Copy Markdown
Contributor Author

tbgowda commented Mar 11, 2022

This is a double commit of #975.

a. it is tested on cisco platforms
b. don't have access to other platforms

@sachinv-msft sachinv-msft requested review from kcudnik and yxieca April 7, 2022 05:36
Copy link
Copy Markdown
Collaborator

@kcudnik kcudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please forward this change to master

@tbgowda
Copy link
Copy Markdown
Contributor Author

tbgowda commented May 12, 2022

Thank you! will do. Please help merge the change so that it can be released into sonic-buildimage.

@kcudnik kcudnik merged commit 45b310d into sonic-net:202012 May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants