[vslib]: hostif enum capability query API support

vslib support for SAI_OBJECT_TYPE_HOSTIF_TRAP,
attribute - SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE

HLD: sonic-net/SONiC#1943

Signed-off-by: Ravi Minnikanti <[email protected]>

Author: rminnikanti

unittest/vslib/TestVirtualSwitchSaiInterface.cpp

@@ -4,6 +4,11 @@
 #include <vector>
 #include <array>
 
+extern "C" {
+#include "sai.h"
+#include "saimetadatautils.h"
+}
+
 #include <gtest/gtest.h>
 
 #include "ContextConfigContainer.h"
@@ -235,3 +240,42 @@ TEST_F(VirtualSwitchSaiInterfaceTest, queryStatsStCapability)
                   &stats_capability));
     EXPECT_EQ(stats_capability.list[0].minimal_polling_interval, static_cast<uint64_t>(1e6 * 100));
 }
+
+TEST_F(VirtualSwitchSaiInterfaceTest, switchHostifTrapCapabilityGet)
+{
+    sai_s32_list_t enum_values_capability = { .count = 0, .list = nullptr };
+
+    sai_status_t status = m_vssai->queryAttributeEnumValuesCapability(
+        m_swid,
+        SAI_OBJECT_TYPE_HOSTIF_TRAP,
+        SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE,
+        &enum_values_capability);
+
+    ASSERT_EQ(status, SAI_STATUS_BUFFER_OVERFLOW);
+
+    const auto* meta = sai_metadata_get_attr_metadata(SAI_OBJECT_TYPE_HOSTIF_TRAP,
+        SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE);
+    assert(meta != NULL && meta->isenum);
+
+    size_t expected_enum_count = meta->enummetadata->valuescount;
+
+    std::vector<int32_t> values_list(expected_enum_count);
+    enum_values_capability.count = static_cast<uint32_t>(values_list.size());
+    enum_values_capability.list = values_list.data();
+
+    status = m_vssai->queryAttributeEnumValuesCapability(
+        m_swid,
+        SAI_OBJECT_TYPE_HOSTIF_TRAP,
+        SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE,
+        &enum_values_capability);
+
+    ASSERT_EQ(status, SAI_STATUS_SUCCESS);
+    ASSERT_EQ(enum_values_capability.count, expected_enum_count);
+
+    for (uint32_t i = 0; i < enum_values_capability.count; ++i)
+    {
+        int32_t value = enum_values_capability.list[i];
+        EXPECT_GE(value, SAI_HOSTIF_TRAP_TYPE_START);
+        EXPECT_LE(value, SAI_HOSTIF_TRAP_TYPE_END);
+    }
+}

vslib/VirtualSwitchSaiInterface.cpp

@@ -922,6 +922,7 @@ sai_status_t VirtualSwitchSaiInterface::queryAttributeEnumValuesCapability(
     {
         if (enum_values_capability->count < 3)
         {
+            enum_values_capability->count = 3;
             return SAI_STATUS_BUFFER_OVERFLOW;
         }
 
@@ -936,6 +937,7 @@ sai_status_t VirtualSwitchSaiInterface::queryAttributeEnumValuesCapability(
     {
         if (enum_values_capability->count < 2)
         {
+            enum_values_capability->count = 2;
             return SAI_STATUS_BUFFER_OVERFLOW;
         }
 
@@ -949,6 +951,7 @@ sai_status_t VirtualSwitchSaiInterface::queryAttributeEnumValuesCapability(
     {
         if (enum_values_capability->count < 4)
         {
+            enum_values_capability->count = 4;
             return SAI_STATUS_BUFFER_OVERFLOW;
         }
 
@@ -960,6 +963,31 @@ sai_status_t VirtualSwitchSaiInterface::queryAttributeEnumValuesCapability(
 
         return SAI_STATUS_SUCCESS;
     }
+    else if (object_type == SAI_OBJECT_TYPE_HOSTIF_TRAP && attr_id == SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE)
+    {
+        auto meta = sai_metadata_get_attr_metadata(SAI_OBJECT_TYPE_HOSTIF_TRAP, SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE);
+
+        if (meta == NULL || !meta->isenum)
+        {
+            SWSS_LOG_THROW("failed to find metadata for SAI_HOSTIF_TRAP_ATTR_TRAP_TYPE attribute");
+        }
+
+        if (enum_values_capability->count < meta->enummetadata->valuescount)
+        {
+            enum_values_capability->count = static_cast<uint32_t>(meta->enummetadata->valuescount);
+            return SAI_STATUS_BUFFER_OVERFLOW;
+        }
+
+        enum_values_capability->count = static_cast<uint32_t>(meta->enummetadata->valuescount);
+
+        for (uint32_t i = 0; i < enum_values_capability->count; i++)
+        {
+            enum_values_capability->list[i] = meta->enummetadata->values[i];
+        }
+
+        return SAI_STATUS_SUCCESS;
+    }
+
     auto ss = m_switchStateMap.at(switch_id);
     return ss->queryAttrEnumValuesCapability(switch_id, object_type, attr_id, enum_values_capability);