Check prefix length while configuring route#121
Merged
sumukhatv merged 5 commits intosonic-net:masterfrom Aug 10, 2022
Merged
Conversation
prsunny
reviewed
Aug 8, 2022
| if adv_prefix, ok := kv["advertise_prefix"]; ok { | ||
| if adv_prefix == "true" { | ||
| prefix_len, _ := network.Mask.Size() | ||
| if isV4orV6(ip.String()) == 4 { |
Collaborator
There was a problem hiding this comment.
Can we use this - ip.To4()
Collaborator
Author
There was a problem hiding this comment.
The isV4orV6 method is calling ip.To4()
go-server-server/go/default.go
Outdated
| continue | ||
| } | ||
|
|
||
| kv, err := GetKVs(confdb.db_num, generateDBTableKey(confdb.separator, VNET_TB, vnet_id_str)) |
Collaborator
There was a problem hiding this comment.
Can we have a logic to cache this after getting it first time? We can have significantly high number of routes and for each time, checking the DB can be expensive. So suggest a simple logic to set advertisement field for a vnet.
prsunny
approved these changes
Aug 9, 2022
Collaborator
|
please update submodule for master/202012 |
This was referenced Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow only prefixes with length greater than /18 for v4 and equal to /64 for v6