Skip to content

Change response message for conflicting VNI #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sumukhatv merged 1 commit into from
Jul 27, 2022
Merged

Change response message for conflicting VNI #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go-server-server/go/default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,7 +1036,7 @@ func ConfigVrouterVrfIdPost(w http.ResponseWriter, r *http.Request) {
guid := CacheGetVniId(uint32(attr.Vnid))
if guid != "" {
WriteRequestErrorWithSubCode(w, http.StatusConflict, RESRC_EXISTS,
"Object already exists {\"vni\":\"" + strconv.Itoa(attr.Vnid) + "\", \"vnet_name\":\"" + guid +"\"}", []string{}, "")
"Object already exists: {\"vni\":\"" + strconv.Itoa(attr.Vnid) + "\", \"vnet_name\":\"" + guid +"\"}", []string{}, "")
return
}

Expand Down
2 changes: 1 addition & 1 deletion test/test_restapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def test_post_vrouter_duplicate(self, setup_restapi_client):
'vnid': 1001
})
assert r.status_code == 409
assert r.json()['error']['message'] == "Object already exists {\"vni\":\"1001\", \"vnet_name\":\"vnet-guid-1\"}"
assert r.json()['error']['message'] == "Object already exists: {\"vni\":\"1001\", \"vnet_name\":\"vnet-guid-1\"}"

def test_post_vrouter_with_advertise_prefix(self, setup_restapi_client):
_, _, configdb, restapi_client = setup_restapi_client
Expand Down