Make functions also working for SonicV2Connector with decode_responses=True#89
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Oct 22, 2020
Merged
Conversation
qiluo-msft
requested review from
SuvarnaMeenakshi,
jleveque,
lguohan,
prsunny and
tahmed-dev
|
This pull request fixes 1 alert when merging a0c6644 into 3461ae0 - view on LGTM.com fixed alerts:
|
jleveque
approved these changes
Oct 22, 2020
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Looks OK to me. Please wait for other reviewers.
tahmed-dev
approved these changes
Oct 22, 2020
This was referenced Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More context:
We plan to migrate existing SonicV2Connector from
decode_responses=False(default) todecode_responses=Truedecode_responses=True, and remove all theencode()/decode()Interact with Redis by str instead of bytes, migrate to SonicV2Connector withdecode_responses=Truesonic-snmpagent#171encode()/decode(): uses SonicV2Connector withdecode_responses=True, and remove all theencode()/decode()fdbshow and nbrshow use SonicV2Connector with decode_responses=True, and remove all the decode() sonic-utilities#1187decode_responses=Trueas default, so it will smoothly migrate every application [SonicV2Connector] make decode_responses=True as default, so python2 application need no code change when migrated to python3 #93