[port_util] Fix issue in function get_interface_oid_map#114
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Sep 13, 2021
Merged
[port_util] Fix issue in function get_interface_oid_map#114qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
…blocking argument to keyword argument Signed-off-by: liora <liora@nvidia.com>
This was referenced Sep 9, 2021
|
@qiluo-msft could you please help to review or suggest a reviewer? |
qiluo-msft
approved these changes
Sep 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: liora liora@nvidia.com
What I did
Change argument 'blocking' in call to function get_all() to a keyword argument as it should.
How I did it
Add blocking=xxx in function call.
How to verify it
This issue is failing the checkers when updating this submodule hash in sonic-buildimage (see sonic-net/sonic-buildimage#8696).