Implement leak detection improvements in thermalctld#776
Open
fraserg-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Implement leak detection improvements in thermalctld#776fraserg-arista wants to merge 1 commit intosonic-net:masterfrom
fraserg-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
@judyjoseph these are the changes to thermalctld to implement the pmon design. Depends on the changes in sonic-net/sonic-platform-common#637. Marked as a draft because I need to re-check your latest changes to the design to make sure everything still matches. |
Contributor
|
@fraserg-arista please check these PRs again there are some changes |
Contributor
|
@fraserg-arista I have updated your comment in platform API PR : sonic-net/sonic-platform-common#634. Let us know when this PR is ready for review - thx |
judyjoseph
reviewed
Apr 14, 2026
Contributor
|
there is s UT failure causing the build failure .. could you fix ? Also wanted to check if there more changes to this PR can we make it ready for review? |
fraserg-arista
force-pushed
the
master-leak-detection
branch
from
c1f4cc3 to
caef9e2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
@judyjoseph the failure is because it uses some interfaces I added in sonic-net/sonic-platform-common#637 |
fraserg-arista
force-pushed
the
master-leak-detection
branch
from
caef9e2 to
8c62a6b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
fraserg-arista
force-pushed
the
master-leak-detection
branch
from
8c62a6b to
f4d69d5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
fraserg-arista
force-pushed
the
master-leak-detection
branch
from
f4d69d5 to
da966b6
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
fraserg-arista
force-pushed
the
master-leak-detection
branch
from
da966b6 to
5342175
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Also updates the tables to match what is specified in the pmon design doc. Signed-off-by: Fraser Gordon <[email protected]>
fraserg-arista
force-pushed
the
master-leak-detection
branch
from
5342175 to
7e8615c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements the leak detection parts of the pmon design as described in sonic-net/SONiC#2215.
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)