Use github code scanning instead of LGTM#316
Merged
prgeor merged 1 commit intosonic-net:masterfrom Nov 29, 2022
Merged
Conversation
Contributor
Author
|
|
prgeor
approved these changes
Nov 29, 2022
yxieca
pushed a commit
that referenced
this pull request
Jan 4, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Jan 5, 2023
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 12, 2023
Merged
8 tasks
lotus-nexthop
pushed a commit
to lotus-nexthop/sonic-platform-daemons
that referenced
this pull request
Oct 28, 2025
…onic-net#316) - Description Catch both TypeError and AttributeError in CmisApi::get_application_advertisement because an AttributeError will be thrown when updating a dict with None. - Motivation and Context Fix issue found during automation tests - How Has This Been Tested? Manually test Added new unit test Signed-off-by: Stephen Sun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LGTM is deprecated in December 2022. Enable github code scanning instead.
result is pasted in comment.
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)