[thermalctld] fix some redundant removal of state DB tables#315
Merged
prgeor merged 8 commits intosonic-net:masterfrom Dec 9, 2022
Merged
[thermalctld] fix some redundant removal of state DB tables#315prgeor merged 8 commits intosonic-net:masterfrom
prgeor merged 8 commits intosonic-net:masterfrom
Conversation
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Collaborator
|
@vdahiya12 could you update |
prgeor
reviewed
Nov 23, 2022
| self.table._del(name) | ||
| if self.is_chassis_system and self.chassis_table is not None: | ||
| self.chassis_table._del(name) | ||
| if self.is_chassis_system and self.chassis_table is not None: |
Collaborator
There was a problem hiding this comment.
this issue is not seen on fixed platform i.e non-modular chassis?
Contributor
Author
There was a problem hiding this comment.
not sure, need to investgate
prgeor
reviewed
Nov 23, 2022
| if self.is_chassis_system and self.chassis_table is not None: | ||
| self.chassis_table._del(name) | ||
| if self.is_chassis_system and self.chassis_table is not None: | ||
| self.chassis_table._del(name) |
Contributor
Author
There was a problem hiding this comment.
yes, tested on M0 failing device
Collaborator
|
Please add new unit test case and fix the existing test case failure. |
Junchao-Mellanox
requested changes
Nov 25, 2022
| if self.is_chassis_system and self.chassis_table is not None: | ||
| self.chassis_table._del(name) | ||
| if self.is_chassis_system and self.chassis_table is not None: | ||
| self.chassis_table._del(name) |
Collaborator
There was a problem hiding this comment.
where is name defined?
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Collaborator
|
@Junchao-Mellanox any more comments.? LGTM |
Junchao-Mellanox
approved these changes
Dec 9, 2022
prgeor
approved these changes
Dec 9, 2022
yxieca
pushed a commit
that referenced
this pull request
Dec 12, 2022
StormLiangMS
pushed a commit
that referenced
this pull request
Jan 5, 2023
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 12, 2023
Merged
8 tasks
lotus-nexthop
pushed a commit
to lotus-nexthop/sonic-platform-daemons
that referenced
this pull request
Oct 28, 2025
…onic-net#315) * Add get_transceiver_status to API interface * Add test_ccmis support * Add get_transceiver_pm API interface * Add debug log and more description for interface * Remove unnecessary pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR aims to get rid of such messages in syslog when thermalctld, essentially delete keys is getting called twice, causing some redis issues.
This PR gets rid of deleting such keys twice.
Nov 16 00:33:00.566174 sonic INFO pmon#/supervisord: thermalctld Exception ignored in: <function TemperatureUpdater.del at 0xb5dbe810>
Nov 16 00:33:00.566585 sonic INFO pmon#/supervisord: thermalctld Traceback (most recent call last):
Nov 16 00:33:00.566825 sonic INFO pmon#/supervisord: thermalctld File "/usr/local/bin/thermalctld", line 558, in del
Nov 16 00:33:00.567014 sonic INFO pmon#/supervisord: thermalctld table_keys = self.table.getKeys()
Nov 16 00:33:00.567181 sonic INFO pmon#/supervisord: thermalctld File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 2320, in getKeys
Nov 16 00:33:00.567343 sonic INFO pmon#/supervisord: thermalctld return _swsscommon.Table_getKeys(self)
Nov 16 00:33:00.567499 sonic INFO pmon#/supervisord: thermalctld RuntimeError: RedisReply catches system_error: command: 2#015
Nov 16 00:33:00.567658 sonic INFO pmon#/supervisord: thermalctld $4#015
Nov 16 00:33:00.567811 sonic INFO pmon#/supervisord: thermalctld KEYS#015
Nov 16 00:33:00.567964 sonic INFO pmon#/supervisord: thermalctld $18#015
Nov 16 00:33:00.568118 sonic INFO pmon#/supervisord: thermalctld TEMPERATURE_INFO|#15
Nov 16 00:33:00.568273 sonicINFO pmon#/supervisord: thermalctld , reason: Expected to get redis type 2 got type 3, err: NON-STRING-REPLY: Input/output error: Input/output error
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)