Skip to content

[CMIS]Improved 400G link bring up sequence #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prgeor merged 11 commits into from
Jun 28, 2022
Merged

[CMIS]Improved 400G link bring up sequence #254

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
57cb73c
Improved 400G link bring up sequence
prgeor Apr 11, 2022
9b00b47
Event based handling
prgeor Apr 19, 2022
5c42c57
Remove unused functions
prgeor Apr 19, 2022
0204a07
Force DP to remain in DpInitialized State state on admin shutdown
prgeor May 6, 2022
69d3a54
Added test case
prgeor May 10, 2022
b9cb34d
Skip CMIS task manager based upon flag
prgeor May 13, 2022
be6d509
Addressed review comments
prgeor Jun 20, 2022
647cff7
Fix xcvrd crash
prgeor Jun 21, 2022
374972e
Fix test failure
prgeor Jun 22, 2022
b52a3f6
Listen only to 'APPL_DB's admin_status
prgeor Jun 23, 2022
3d25e45
Fix typo
prgeor Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sonic-xcvrd/xcvrd/xcvrd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,10 @@ def on_port_update_event(self, port_change_event):
self.port_dict[lport]['lanes'] = port_change_event.port_dict['lanes']
if 'host_tx_ready' in port_change_event.port_dict:
self.port_dict[lport]['host_tx_ready'] = port_change_event.port_dict['host_tx_ready']
if 'admin_status' in port_change_event.port_dict:
if 'admin_status' in port_change_event.port_dict and 'oper_status' in port_change_event.dict:
Copy link
Copy Markdown

@jaganbal-a jaganbal-a Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in port_change_event.dict: -> in port_change_event.port_dict:

# At times 'admin_status' is NOT the same in the PORT_TABLE of APPL_DB and STATE_DB
# We dont have better way to check if 'admin_status' is from APPL_DB or STATE_DB so this
# check is put temporarily to list only to APPL_DB's admin_status and ignore that of STATE_DB
Copy link
Copy Markdown

@shyam77git shyam77git Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of 'list only' it should be 'listen only'

self.port_dict[lport]['admin_status'] = port_change_event.port_dict['admin_status']
self.force_cmis_reinit(lport, 0)
else:
Expand Down