-
Notifications
You must be signed in to change notification settings - Fork 209
[xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vdahiya12
merged 17 commits into
sonic-net:master
from
vdahiya12:abstract_class_changes
Aug 25, 2021
Merged
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
368ff10
[xcvrd] initial support for integrating vendor specfic class objects …
vdahiya12 59ad9a8
fix few comments and LGTM
vdahiya12 1011704
fix comments
vdahiya12 9101261
fix comments
vdahiya12 c840e95
fix logic
vdahiya12 27deae5
remove y_cable import
vdahiya12 7091782
fix cli logic
vdahiya12 825786e
fix LGTM
vdahiya12 ce6782a
fix some logic
vdahiya12 be8c1aa
add unit tests
vdahiya12 b2db691
fix unit
vdahiya12 52ad70d
fix some logs
vdahiya12 db13a08
fix some logging
vdahiya12 d9f06fb
fix the LGTM
vdahiya12 3108548
fix some more logging
vdahiya12 b1f916a
add support for simulator;cleanup some logic
vdahiya12 6c47af4
fix lgtm
vdahiya12 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is being tested in this test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an assert for return code
fixed