[thermalctld] Initialize fan led in thermalctld for the first run#167
Merged
jleveque merged 1 commit intosonic-net:masterfrom Mar 22, 2021
Merged
[thermalctld] Initialize fan led in thermalctld for the first run#167jleveque merged 1 commit intosonic-net:masterfrom
jleveque merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
@Junchao-Mellanox could it be an additional change to sonic-net/sonic-buildimage#7114 |
liat-grozovik
approved these changes
Mar 22, 2021
jleveque
approved these changes
Mar 22, 2021
4 tasks
This was referenced May 21, 2021
jleveque
pushed a commit
that referenced
this pull request
May 27, 2021
Backport PR #167 since there is no clean cherry-pick. #### Description Initialize fan led in thermalcltd for the first run. Add a flag "led_initialized" in FanStatus and set it as False on __init__ function. FanUpdater will use this flag to determine if fan led should be set even if no fan event detected.
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
Add GitHub pull request template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize fan led in thermalcltd for the first run. Add a flag "led_initialized" in FanStatus and set it as False on init function. FanUpdater will use this flag to determine if fan led should be set even if no fan event detected.
Motivation and Context
Make sure fan led is initialized to correct color.
How Has This Been Tested?
Manual test
Additional Information (Optional)