Fix test_updater_thermal_check_min_max() failure#121
Merged
jleveque merged 1 commit intosonic-net:masterfrom Nov 20, 2020
Merged
Fix test_updater_thermal_check_min_max() failure#121jleveque merged 1 commit intosonic-net:masterfrom
jleveque merged 1 commit intosonic-net:masterfrom
Conversation
Contributor
Author
Signed-off-by: Petro Bratash <[email protected]>
bratashX
force-pushed
the
fix_thermalctld_tests
branch
from
490e028 to
85c7cb0
Compare
Contributor
Author
|
@jleveque, I see that you workaround CI problem, could you please review PR that should fix this issue? |
Contributor
|
@bratashX: Thank you for this fix! @Junchao-Mellanox: Please review. |
Junchao-Mellanox
approved these changes
Nov 20, 2020
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…t#121) Add a new function to TlvInfoDecoder which can return device part number as a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On this PR was changed name generation:
and after this changes test_updater_thermal_check_min_max() fails:
Signed-off-by: Petro Bratash [email protected]