[xcvrd] Add enum dependence back; Install 'enum34' conditionally based on Python version#107
Merged
jleveque merged 3 commits intosonic-net:masterfrom Nov 3, 2020
jleveque:fix_enum
Merged
[xcvrd] Add enum dependence back; Install 'enum34' conditionally based on Python version#107jleveque merged 3 commits intosonic-net:masterfrom jleveque:fix_enum
jleveque merged 3 commits intosonic-net:masterfrom
jleveque:fix_enum
Conversation
added 2 commits
October 31, 2020 01:27
jleveque
changed the title
msosyak
approved these changes
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dependence on 'enum' package back to xcvrd (basically reverting most of #106). However, in setup.py, we only install the enum34 package if the version of Python we are installing for is < 3.4. Thus, when installing the Python 3 xcvrd package in Python 2.7, the Python 2 version of enum34 will be installed. However, if installing the Python 3 xcvrd package on Python 3.7, enum34 will not be installed, causing xcrvd to import the 'enum' module from the standard library. This should prevent any conflicts which arise when 'enum34' is ever installed on Python versions >= 3.4 by preventing this situation.