Skip to content

[sonic_sfp] fix syntax error in sfputilbase._read_eeprom_specific_bytes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jleveque merged 2 commits into from
Sep 5, 2019
Merged

[sonic_sfp] fix syntax error in sfputilbase._read_eeprom_specific_bytes #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5abb311
[sonic_sfp.sfputilbase] fix syntax error in _read_eeprom_specific_bytes
Aug 28, 2019
ce44521
[sonic_sfp] rephase
Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sonic_sfp/sfputilbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,10 @@ def _read_eeprom_specific_bytes(self, sysfsfile_eeprom, offset, num_bytes):
sysfsfile_eeprom.seek(offset)
raw = sysfsfile_eeprom.read(num_bytes)
except IOError:
print("Error: reading sysfs file %s" % sysfs_sfp_i2c_client_eeprom_path)
if sysfsfile_eeprom is not None:
print("Error: reading sysfs file %s" % sysfsfile_eeprom.name)
else:
print("Error: reading sysfs, file doesn't exist")
return None

try:
Expand Down