Add negative case for pci_detach() and pci_reattach()#504
Merged
prgeor merged 7 commits intosonic-net:masterfrom Nov 9, 2024
Merged
Add negative case for pci_detach() and pci_reattach()#504prgeor merged 7 commits intosonic-net:masterfrom
prgeor merged 7 commits intosonic-net:masterfrom
Conversation
rameshraghupathy
approved these changes
Oct 9, 2024
gpunathilell
reviewed
Nov 1, 2024
Also, remove module_name from pci_detach() and get_bus_info()
vvolam
changed the title
vvolam
requested review from
gpunathilell and
rameshraghupathy
and removed request for
gpunathilell
oleksandrivantsiv
approved these changes
Nov 5, 2024
Collaborator
|
@vvolam please add more details in the PR description. |
prgeor
reviewed
Nov 5, 2024
prgeor
reviewed
Nov 5, 2024
prgeor
reviewed
Nov 7, 2024
prgeor
reviewed
Nov 7, 2024
prgeor
reviewed
Nov 7, 2024
prgeor
reviewed
Nov 7, 2024
vvolam
changed the title
prgeor
approved these changes
Nov 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address the comments added in #501
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)