Skip to content

Add parser support for Tx_RxLos,TxFault, PowerControl, ResetStatus in sff8436.py#45

Merged
jleveque merged 9 commits intosonic-net:masterfrom
sridhar-ravindran:platform_2_0
Jul 29, 2019
Merged

Add parser support for Tx_RxLos,TxFault, PowerControl, ResetStatus in sff8436.py#45
jleveque merged 9 commits intosonic-net:masterfrom
sridhar-ravindran:platform_2_0

Conversation

@sridhar-ravindran
Copy link
Contributor

Pull Request to add parser support for the following data in sff8436.py file

DataNotReady,
TxLos,
RxLos,
TxFault,
TxDisable,
Power Control

Also implement new api get_transceiver_threshold_info to retrieve EEPROM Dom Threshold Values.

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @keboliu: Please review.

@keboliu
Copy link
Collaborator

keboliu commented Jul 24, 2019

the enhance looks good to me, one thing is that can you make sonic_sfp as a symbolic link to sonic_platform_base/sonic_sfp so we don't need to maintain the duplicated files?

@sridhar-ravindran
Copy link
Contributor Author

sridhar-ravindran commented Jul 24, 2019

Hi @keboliu
I see may diff between directories.
$sonic-platform-common>diff sonic_sfp/ sonic_platform_base/sonic_sfp/ > diff_between_dirs

Attached the diff file. Since it involves lot of changes, can we clean it up via another new pull request ?

Thanks
Sridhar.R
diff_between_dirs.txt

@keboliu
Copy link
Collaborator

keboliu commented Jul 29, 2019

Hi @keboliu
I see may diff between directories.
$sonic-platform-common>diff sonic_sfp/ sonic_platform_base/sonic_sfp/ > diff_between_dirs

Attached the diff file. Since it involves lot of changes, can we clean it up via another new pull request ?

Thanks
Sridhar.R
diff_between_dirs.txt

OK.

@sridhar-ravindran
Copy link
Contributor Author

Hi @jleveque @keboliu

Thanks for the approval.
Request you to merge the changes.

@jleveque jleveque merged commit 3bb3703 into sonic-net:master Jul 29, 2019
@sridhar-ravindran sridhar-ravindran deleted the platform_2_0 branch July 29, 2019 18:14
jleveque pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Aug 14, 2019
[sonic-platform-common]

[sonic_sfp] Interpret sff 'int' element =0 as valid value (sonic-net/sonic-platform-common#51)
add more error code to get_transceiver_change_event ((sonic-net/sonic-platform-common#50)
[sonic_platform_base] support new-platform-api-based daemons ((sonic-net/sonic-platform-common#48)
sync change to sonic_platform_base/sonic_sfp and create symbol link ((sonic-net/sonic-platform-common#49)
Add parser support for Tx_RxLos,TxFault, PowerControl, ResetStatus in sff8436.py ((sonic-net/sonic-platform-common#45)
readd type_abbrv_name in sonic_sfp/sff8436.py ((sonic-net/sonic-platform-common#44)
[psu_base] get_status_led() returns current state of the status LED ((sonic-net/sonic-platform-common#39)
Fix abbrv name for OSFP ((sonic-net/sonic-platform-common#36)
[sff8436] support "Control Bytes" and "Options" ((sonic-net/sonic-platform-common#38)
sonic_sfp: avoid possible key error in get_physical_to_logical() ((sonic-net/sonic-platform-common#37)

[sonic-platform-daemons]

[xcvrd] Enhance xcvrd to handle new system level event/error (sonic-net/sonic-platform-daemons#39)
[xcvrd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#38)
[psud] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#37)
[syseepromd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#36)
Add missing import statemet (sonic-net/sonic-platform-daemons#32)
sonic_xcvrd: Support for DOM Threshold values for EEPROM dump (sonic-net/sonic-platform-daemons#29)
wangshengjun pushed a commit to wangshengjun/sonic-buildimage that referenced this pull request Nov 16, 2020
…ic-net#3333)

[sonic-platform-common]

[sonic_sfp] Interpret sff 'int' element =0 as valid value (sonic-net/sonic-platform-common#51)
add more error code to get_transceiver_change_event ((sonic-net/sonic-platform-common#50)
[sonic_platform_base] support new-platform-api-based daemons ((sonic-net/sonic-platform-common#48)
sync change to sonic_platform_base/sonic_sfp and create symbol link ((sonic-net/sonic-platform-common#49)
Add parser support for Tx_RxLos,TxFault, PowerControl, ResetStatus in sff8436.py ((sonic-net/sonic-platform-common#45)
readd type_abbrv_name in sonic_sfp/sff8436.py ((sonic-net/sonic-platform-common#44)
[psu_base] get_status_led() returns current state of the status LED ((sonic-net/sonic-platform-common#39)
Fix abbrv name for OSFP ((sonic-net/sonic-platform-common#36)
[sff8436] support "Control Bytes" and "Options" ((sonic-net/sonic-platform-common#38)
sonic_sfp: avoid possible key error in get_physical_to_logical() ((sonic-net/sonic-platform-common#37)

[sonic-platform-daemons]

[xcvrd] Enhance xcvrd to handle new system level event/error (sonic-net/sonic-platform-daemons#39)
[xcvrd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#38)
[psud] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#37)
[syseepromd] Support both new platform API and old platform plugins (sonic-net/sonic-platform-daemons#36)
Add missing import statemet (sonic-net/sonic-platform-daemons#32)
sonic_xcvrd: Support for DOM Threshold values for EEPROM dump (sonic-net/sonic-platform-daemons#29)
Junchao-Mellanox pushed a commit to Junchao-Mellanox/sonic-platform-common that referenced this pull request Mar 20, 2025
… 202412 (sonic-net#45)

```<br>* 5060449 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-03-02) [Sonic Automation]
* c735073 - (origin/202411) [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin]
* b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants