Fix issues in cmis.get_transceiver_bulk_status#351
Merged
prgeor merged 4 commits intosonic-net:masterfrom Mar 15, 2023
Merged
Conversation
1. In case it fails to read EEPROM, either self.get_rx_power() or self.get_tx_power() can be a list of 'N/A'. Need to test it before calling self.mw_to_dbm 2. It should be a valid case for either self.get_rx_power() or self.get_tx_power() to return None. Handle other fields instead of returning None in this case Signed-off-by: Stephen Sun <stephens@nvidia.com>
Junchao-Mellanox
previously approved these changes
Mar 6, 2023
Collaborator
Author
|
It can be cleanly cherry-picked to both 202205 and 202211 202211: |
Collaborator
|
@prgeor could you please help review or assign someone? |
Collaborator
|
@stephenxs please provide more context in the description. What is failing? Which CLI? If the i2c read is failing then we should fix the optics or platform issue? |
prgeor
reviewed
Mar 7, 2023
Collaborator
Author
@prgeor Updated in the description. |
keboliu
previously approved these changes
Mar 7, 2023
Collaborator
|
@prgeor as this issue is for 202205 please review so we can have it in soon. thanks. |
prgeor
reviewed
Mar 14, 2023
…ading failure Signed-off-by: Stephen Sun <stephens@nvidia.com>
f02c287
Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor
reviewed
Mar 15, 2023
prgeor
reviewed
Mar 15, 2023
Signed-off-by: Stephen Sun <stephens@nvidia.com>
prgeor
approved these changes
Mar 15, 2023
Collaborator
|
@yxieca please cherry pick to 202205 |
Collaborator
|
@StormLiangMS please help cherry pick to 202211 |
yxieca
pushed a commit
that referenced
this pull request
Mar 15, 2023
* Fix issue in cmis.get_transceiver_bulk_status 1. In case it fails to read EEPROM, either self.get_rx_power() or self.get_tx_power() can be a list of 'N/A'. Need to test it before calling self.mw_to_dbm 2. It should be a valid case for either self.get_rx_power() or self.get_tx_power() to return None. Handle other fields instead of returning None in this case Signed-off-by: Stephen Sun <stephens@nvidia.com> * Address comments: distinguish scenarios between not supporting and reading failure Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust unit test case Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove redundant code Signed-off-by: Stephen Sun <stephens@nvidia.com> --------- Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 19, 2023
* Fix issue in cmis.get_transceiver_bulk_status 1. In case it fails to read EEPROM, either self.get_rx_power() or self.get_tx_power() can be a list of 'N/A'. Need to test it before calling self.mw_to_dbm 2. It should be a valid case for either self.get_rx_power() or self.get_tx_power() to return None. Handle other fields instead of returning None in this case Signed-off-by: Stephen Sun <stephens@nvidia.com> * Address comments: distinguish scenarios between not supporting and reading failure Signed-off-by: Stephen Sun <stephens@nvidia.com> * Adjust unit test case Signed-off-by: Stephen Sun <stephens@nvidia.com> * Remove redundant code Signed-off-by: Stephen Sun <stephens@nvidia.com> --------- Signed-off-by: Stephen Sun <stephens@nvidia.com>
Collaborator
|
commits already included in 202211, so I add the label. |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
sonic-net#351) * PSUD-Delete or update CHASSIS_INFO table PSU/Modules data if added or removed. Signed-off-by: prem-nokia <premnath.saravanan@nokia.com> * fix swsscommon.py hdel function. * implemented code optimization. Signed-off-by: premsara <premnath.saravanan@nokia.com> --------- Signed-off-by: prem-nokia <premnath.saravanan@nokia.com> Signed-off-by: premsara <premnath.saravanan@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issues in cmis.get_transceiver_bulk_status
TypeError("'<' not supported between instances of 'str' and 'int'")will be thrown.Motivation and Context
How Has This Been Tested?
Additional Information (Optional)