CmisApi::get_application_advertisement catch AttributeError as well #316
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Oct 30, 2022
Merged
Conversation
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
keboliu
approved these changes
Oct 25, 2022
Collaborator
|
@stephenxs thanks for the fix. do we also need it on 202205? |
Collaborator
Author
Yes. Label added. |
liat-grozovik
approved these changes
Oct 30, 2022
liat-grozovik
changed the title
yxieca
pushed a commit
that referenced
this pull request
Nov 3, 2022
…316) - Description Catch both TypeError and AttributeError in CmisApi::get_application_advertisement because an AttributeError will be thrown when updating a dict with None. - Motivation and Context Fix issue found during automation tests - How Has This Been Tested? Manually test Added new unit test Signed-off-by: Stephen Sun <stephens@nvidia.com>
7 tasks
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Catch both
TypeErrorandAttributeErrorinCmisApi::get_application_advertisementbecause an AttributeError will be thrown when updating a dict withNone.Motivation and Context
How Has This Been Tested?
Manually test
Added unit test
Additional Information (Optional)