Skip to content

[credo][ycable] remove mux-toggle inprogress flags for some API's#311

Merged
vdahiya12 merged 1 commit intosonic-net:masterfrom
vdahiya12:pcom-rm
Sep 23, 2022
Merged

[credo][ycable] remove mux-toggle inprogress flags for some API's#311
vdahiya12 merged 1 commit intosonic-net:masterfrom
vdahiya12:pcom-rm

Conversation

@vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Sep 23, 2022

this PR removes some of the toggle synchronization logic for SONiC telemetry, since SONiC telemetry table MUX_CABLE_INFO is anyways disabled/enabled using CLI
config muxcable telemetry enable/disable, it is redundant to have this logic embedded in ycabled and port_instance helper objects, which could be unneccessary

Signed-off-by: vaibhav-dahiya [email protected]

Description

Motivation and Context

How Has This Been Tested?

Deploying changes on Arista testbed

Additional Information (Optional)

@vdahiya12 vdahiya12 requested a review from zjswhhh September 23, 2022 21:27
@vdahiya12 vdahiya12 merged commit b26aa5e into sonic-net:master Sep 23, 2022
qiluo-msft pushed a commit that referenced this pull request Sep 23, 2022
this PR removes some of the toggle synchronization logic for SONiC telemetry, since SONiC telemetry table MUX_CABLE_INFO is anyways disabled/enabled using CLI
config muxcable telemetry enable/disable, it is redundant to have this logic embedded in ycabled and port_instance helper objects, which could be unneccessary

Signed-off-by: vaibhav-dahiya [email protected]

Signed-off-by: vaibhav-dahiya <[email protected]>
yxieca pushed a commit that referenced this pull request Oct 3, 2022
this PR removes some of the toggle synchronization logic for SONiC telemetry, since SONiC telemetry table MUX_CABLE_INFO is anyways disabled/enabled using CLI
config muxcable telemetry enable/disable, it is redundant to have this logic embedded in ycabled and port_instance helper objects, which could be unneccessary

Signed-off-by: vaibhav-dahiya [email protected]

Signed-off-by: vaibhav-dahiya <[email protected]>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
…table (sonic-net#311)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>

Description
The following changes are done in chassisd

Change the ModuleUpdater init changed to include slot and supervisor as argument.
Add logic to in ModuleUpdater to update the asic_info in CHASSIS_FABRIC_ASIC_INFO for the supervisor and CHASSIS_ASIC_TABLE for the linecard asics respectively.
Add the linecard name is the key of the CHASSIS_ASIC_TABLE
update the UT
Motivation and Context
Fixes sonic-net/sonic-buildimage#12575 and sonic-net/sonic-buildimage#12575

How Has This Been Tested?
Update the pmon on the supervisor and linecard and verify the CHASSIS_STATE_DB is update properly

admin@str2-sonic-sup-1:~$ redis-cli -h redis_chassis.server -p 6380 -n 13 keys *ASIC*
 1) "CHASSIS_ASIC_TABLE|LINE-CARD4|asic0"
 2) "CHASSIS_FABRIC_ASIC_TABLE|asic1"
 3) "CHASSIS_FABRIC_ASIC_TABLE|asic8"
 4) "CHASSIS_FABRIC_ASIC_TABLE|asic10"
 5) "CHASSIS_ASIC_TABLE|LINE-CARD0|asic0"
 6) "CHASSIS_FABRIC_ASIC_TABLE|asic6"
 7) "CHASSIS_FABRIC_ASIC_TABLE|asic9"
 8) "CHASSIS_FABRIC_ASIC_TABLE|asic5"
 9) "CHASSIS_FABRIC_ASIC_TABLE|asic3"
10) "CHASSIS_ASIC_TABLE|LINE-CARD3|asic0"
11) "CHASSIS_FABRIC_ASIC_TABLE|asic2"
12) "CHASSIS_ASIC_TABLE|LINE-CARD2|asic0"
13) "CHASSIS_ASIC_TABLE|LINE-CARD2|asic1"
14) "CHASSIS_FABRIC_ASIC_TABLE|asic11"
15) "CHASSIS_FABRIC_ASIC_TABLE|asic0"
16) "CHASSIS_FABRIC_ASIC_TABLE|asic4"
17) "CHASSIS_FABRIC_ASIC_TABLE|asic7"
admin@str2-sonic-sup-1:~$
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants