Skip to content

[sonic_fw]: Add firmware management api base#30

Closed
mudsut4ke wants to merge 1 commit intosonic-net:masterfrom
mudsut4ke:add-new-fwutil
Closed

[sonic_fw]: Add firmware management api base#30
mudsut4ke wants to merge 1 commit intosonic-net:masterfrom
mudsut4ke:add-new-fwutil

Conversation

@mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Apr 26, 2019

Add base class for firmware management utillity (sonic-net/sonic-buildimage#2824)

Signed-off-by: Wirut Getbamrung [email protected]

This was referenced Apr 26, 2019
Closed
Closed
@lguohan lguohan requested a review from jleveque May 9, 2019 07:27
lguohan
lguohan reviewed May 9, 2019
View reviewed changes
sonic_fw/fw_manage_base.py
"module_name": "CPLD",
"fw_version": {
"CPLD1" : "1.0.0",
"CPLD2" : "1.1.0"
Copy link
Contributor

@lguohan lguohan May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case, i feel we should have CPLD1, CPLD2 as module name, each module will have only one version.

Copy link
Contributor Author

@mudsut4ke mudsut4ke May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case,the list of supported module will be ["BIOS", "CPLD1", "CPLD2"] instead of ["BIOS", "CPLD"] and get_fw_version function should return only version string

Is that good?

Copy link
Contributor

@lguohan lguohan May 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

@lguohan lguohan Jun 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the comments?

@jleveque
Copy link
Contributor

jleveque commented May 9, 2019

@mudsut4ke: Is there any reason to keep this as a separate sonic_fw package, or would be better to add get_fw_version() and install_firmware() methods to the ChassisBase and ModuleBase classes sonic_platform_base?

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented May 13, 2019

@jleveque , Maybe a reason that firmware install tool is installed in sonic platform and cannot be used on pmon docker

@jleveque
Copy link
Contributor

jleveque commented May 13, 2019 •
edited
Loading

@mudsut4ke: Can you elaborate? We would like to consolidate all platform-specific abstraction into the new sonic_platform_base package.

If we were to install the sonic_platform_base package in both the pmon docker and also in the base image, would this suffice?

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented May 15, 2019

@jleveque , In my case the CPLD upgrade tool installed in base image (sonic-net/sonic-buildimage#2446)

if you install sonic_platform_base package in both the pmon docker and base image, that will cover my requirement

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented May 27, 2019

@jleveque , Any comment?

@jleveque
Copy link
Contributor

jleveque commented May 28, 2019

I think it would be best to add this functionality to the ChassisBase and ModuleBase classes in the new platform API, and we can install the package in the base image as well as the pmon container.

@lguohan
Copy link
Contributor

lguohan commented Jun 6, 2019

@mudsut4ke , any update on this?

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented Jun 10, 2019

@lguohan , I will move this tool to sonic_platform_base follow Joe suggesttion

@jleveque , In ChassisBase they Identified BIOS/FPGA/CPLD as component
Should I add new ComponentBase ? or Just add the firmware management to ModuleBase is enough ?

@jleveque
Copy link
Contributor

jleveque commented Jun 10, 2019

@mudsut4ke: I think adding the firmware management functions to ChassisBase and ModuleBase is enough.

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented Jun 14, 2019 •
edited
Loading

Move to #34

@mudsut4ke mudsut4ke closed this Jun 14, 2019
@mudsut4ke mudsut4ke mentioned this pull request Jun 17, 2019
Merged
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
@keboliu @jleveque
[xcvrd] Fix missing sfp info table entry issue (sonic-net#30)
6618737
jianyuewu pushed a commit to jianyuewu/sonic-platform-common that referenced this pull request May 7, 2025
@mssonicbld
[code sync] Merge code from sonic-net/sonic-platform-common:202411 to…
85c9572 
… 202412 (sonic-net#30)

```<br>* f0d6c81 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-platform-common into 202412 (2025-02-19) [Sonic Automation]
* c735073 - (origin/202411) [202411][cmis] Fix cmis.get_error_description speed for passive module (sonic-net#538) (2025-02-12) [Aryeh Feigin]
* b7e75d8 - Add 800G innolight PNs (sonic-net#540) (2025-02-07) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan left review comments

@jleveque jleveque Awaiting requested review from jleveque

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mudsut4ke @jleveque @lguohan