[Credo][Ycable] fix incorrect uart statistics#296
Merged
vdahiya12 merged 2 commits intosonic-net:masterfrom Aug 12, 2022
Merged
[Credo][Ycable] fix incorrect uart statistics#296vdahiya12 merged 2 commits intosonic-net:masterfrom
vdahiya12 merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: xinyu <xinyu0123@gmail.com>
|
This pull request introduces 1 alert when merging 56afe8a into 50c24a5 - view on LGTM.com new alerts:
|
xinyulin
force-pushed
the
credo_dump_reg
branch
from
4e3d8f0 to
fe2c020
Compare
Signed-off-by: xinyu <xinyu0123@gmail.com>
xinyulin
force-pushed
the
credo_dump_reg
branch
from
fe2c020 to
9d2ba33
Compare
Contributor
|
/easycla |
vdahiya12
approved these changes
Aug 12, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 12, 2022
Description The original get_uart_stat() will only report the last record of the uart statistic due to all record shared the same object instance. Motivation and Context How Has This Been Tested? Signed-off-by: xinyu <xinyu0123@gmail.com>
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 29, 2022
Update sonic-platform-common submodule pointer to include the following: * [CMIS] Catch Exception to avoid CMIS code crash ([sonic-net#299](sonic-net/sonic-platform-common#299)) * [Credo][Ycable] fix incorrect uart statistics ([sonic-net#296](sonic-net/sonic-platform-common#296)) * Add PSU input voltage and input current ([sonic-net#295](sonic-net/sonic-platform-common#295)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 4, 2022
Update sonic-platform-common submodule pointer to include the following: * [CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready ([sonic-net#305](sonic-net/sonic-platform-common#305)) * uplift code coverage 80% ([sonic-net#307](sonic-net/sonic-platform-common#307)) * [sonic-pcie] Add UT for pcie_common.py ([sonic-net#293](sonic-net/sonic-platform-common#293)) * [CMIS] Catch Exception to avoid CMIS code crash ([sonic-net#299](sonic-net/sonic-platform-common#299)) * [Credo][Ycable] fix incorrect uart statistics ([sonic-net#296](sonic-net/sonic-platform-common#296)) * Add PSU input voltage and input current ([sonic-net#295](sonic-net/sonic-platform-common#295)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Aug 10, 2023
Description The original get_uart_stat() will only report the last record of the uart statistic due to all record shared the same object instance. Motivation and Context How Has This Been Tested? Signed-off-by: xinyu <xinyu0123@gmail.com>
yxieca
added
Cherry Pick Conflict_202205
Included in 202205 Branch
and removed
Cherry Pick Conflict_202205
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xinyu xinyu0123@gmail.com
Description
The original get_uart_stat() will only report the last record of the uart statistic due to all record shared the same object instance.
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)