Fix AttributeError for "sfputil show error-status -hw"#291
Merged
prgeor merged 1 commit intosonic-net:masterfrom Jul 12, 2022
chiourung:get_error_description
Merged
Fix AttributeError for "sfputil show error-status -hw"#291prgeor merged 1 commit intosonic-net:masterfrom chiourung:get_error_description
prgeor merged 1 commit intosonic-net:masterfrom
chiourung:get_error_description
Conversation
When insert trasnceiver which is not QSFP-DD, "sfputil show error-status -hw" would fail
error:
File "/usr/local/lib/python3.7/dist-packages/sonic_platform_base/sonic_xcvr/sfp_optoe_base.py", line 211, in get_error_description
return api.get_error_description() if api is not None else None
AttributeError: 'Sff8636Api' object has no attribute 'get_error_description'
Signed-off-by: chiourung_huang <[email protected]>
prgeor
approved these changes
Jul 12, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When insert trasnceiver which is not QSFP-DD, "sfputil show error-status -hw" would fail
error:
Signed-off-by: chiourung_huang [email protected]
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)