Skip to content

Fix Cmis memmap field offset#290

Merged
prgeor merged 1 commit intosonic-net:masterfrom
prgeor:cmis-offset
Jul 13, 2022
Merged

Fix Cmis memmap field offset#290
prgeor merged 1 commit intosonic-net:masterfrom
prgeor:cmis-offset

Conversation

@prgeor
Copy link
Collaborator

@prgeor prgeor commented Jul 6, 2022

Description

Fix wrong field offset for HostLaneAssignementOption for applications 9 to 15 in CMIS memmap

Motivation and Context

  1. Wrong field offset for host lane map assignment
  2. Updated the frequency setting API for ZR module. No need to include sleep and force low power mode, as the these are managed by Xcvrd, so just update or configure the required frequency.

How Has This Been Tested?

Setting laser frequency

root@sonic:~# config interface transceiver frequency Ethernet0 193175
Setting laser frequency to 193175 GHz on port Ethernet0
root@sonic:~# config interface transceiver frequency Ethernet16 193175
Setting laser frequency to 193175 GHz on port Ethernet16
root@sonic:~#

Verifying the same

>>> from sonic_platform.platform import Platform
>>> p = Platform()
>>> c = p.get_chassis()
>>> sfp = c.get_sfp(1)
>>> api = sfp.get_xcvr_api()
>>> api.get_current_laser_freq()
193175.0
>>>

Also, verified the link is DOWN if same freq is not configured on the peer port and link comes UP if same freq is configured on the peer.

Additional Information (Optional)

Copy link
Contributor

@snider-nokia snider-nokia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMIS memory map application advertising changes look good. Assuming here that the (unrelated) LP mode changes in set_laser_freq(...) API are also correct.

@prgeor prgeor added the Bug label Jul 12, 2022
@prgeor
Copy link
Collaborator Author

prgeor commented Jul 12, 2022

@qinchuanares please review

@qinchuanares
Copy link
Contributor

@prgeor please include the test results for change frequency on two cross-connected 400ZR plugs in this PR.

@lguohan
Copy link
Contributor

lguohan commented Jul 12, 2022

is there an issue? can you associate with the issue if there is.

@prgeor
Copy link
Collaborator Author

prgeor commented Jul 13, 2022

is there an issue? can you associate with the issue if there is.

No, it was reported by Marc from Nokia. We did not see any issue so far because this offset is not accessed today.

@prgeor
Copy link
Collaborator Author

prgeor commented Jul 13, 2022

@prgeor please include the test results for change frequency on two cross-connected 400ZR plugs in this PR.

@qinchuanares added test results.

@prgeor
Copy link
Collaborator Author

prgeor commented Aug 23, 2022

@yxieca could you cherry-pick this one to 202205. Added request label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants