Skip to content

Support get_port_or_cage_type#288

Merged
prgeor merged 2 commits intosonic-net:masterfrom
stephenxs:support_get_port_or_cage_type
Jul 8, 2022
Merged

Support get_port_or_cage_type#288
prgeor merged 2 commits intosonic-net:masterfrom
stephenxs:support_get_port_or_cage_type

Conversation

@stephenxs
Copy link
Collaborator

The API returns the masks of all types of port or cage that can be supported on the port
All the types are defined in sfp_base.SfpBase
Currently, the API is used to check whether a port is an RJ45 port so we suggest supporting it at least for RJ45 ports

Signed-off-by: Stephen Sun [email protected]

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

The API returns the masks of all types of port or cage that can be supported on the port
All the types are defined in sfp_base.SfpBase

Signed-off-by: Stephen Sun <[email protected]>
liat-grozovik
liat-grozovik previously approved these changes Jul 6, 2022
@liat-grozovik
Copy link
Collaborator

@prgeor could you please help to review?

@prgeor prgeor merged commit 912797e into sonic-net:master Jul 8, 2022
@stephenxs stephenxs deleted the support_get_port_or_cage_type branch July 8, 2022 21:38
yxieca pushed a commit that referenced this pull request Jul 28, 2022
* Support get_port_or_cage_type

The API returns the masks of all types of port or cage that can be supported on the port
All the types are defined in sfp_base.SfpBase

Signed-off-by: Stephen Sun <[email protected]>

* Add comments to explain the types

Signed-off-by: Stephen Sun <[email protected]>
Arista-Jenkins pushed a commit to aristanetworks/sonic that referenced this pull request Aug 26, 2022
This new API method was introduced by sonic-net/sonic-platform-common#288

Change-Id: Ic04496089c0d6767210ae86320ee4fee38fe17c0
Arista-Jenkins pushed a commit to aristanetworks/sonic that referenced this pull request Aug 24, 2023
This new API method was introduced by sonic-net/sonic-platform-common#288

Change-Id: Ic04496089c0d6767210ae86320ee4fee38fe17c0
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-platform-common that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants