[202012][sonic_sfp]: prefer Config DB port index mapping over platform.json/port_config.ini#258
Merged
prgeor merged 5 commits intosonic-net:202012from Jan 18, 2022
Conversation
…ort_config.ini Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 258 in repo Azure/sonic-platform-common |
Collaborator
|
@nazariig could you please check build error |
Collaborator
Author
|
@prgeor seems to be an environmental issue: |
Collaborator
Ack. python2 support has been removed in latest master, so i will have to update the pipeline to skip py2. |
Collaborator
Author
|
@prgeor FYI. This fix is for |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@samaity could you review this change? |
prgeor
requested changes
Jan 17, 2022
prgeor
approved these changes
Jan 18, 2022
Collaborator
|
@nazariig looks like pipeline is failing because its downloading the artifacts from master branch. Can you fix https://github.com/Azure/sonic-platform-common/blob/master/azure-pipelines.yml#L30 as: |
liat-grozovik
approved these changes
Jan 18, 2022
Collaborator
|
/azp run Azure.sonic-platform-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
09e87ce to
bc60f14
Compare
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
bc60f14 to
8ead647
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Approach:
platform.jsonorport_config.iniOn
multiasicplatforms the relevant Config DB instance will be usedMotivation and Context
platform.jsonorport_config.iniif neededHow Has This Been Tested?
Additional Information (Optional)