Skip to content

[SFP-Refactor]Fix vendor revision key issue #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prgeor merged 2 commits into from
Dec 8, 2021
Merged

[SFP-Refactor]Fix vendor revision key issue #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
382c197
Fix vendor revision key issue
aravindmani-1 Dec 6, 2021
44597c4
update sfp_base
aravindmani-1 Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sonic_platform_base/sfp_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ def get_transceiver_info(self):
type |1*255VCHAR |type of SFP
type_abbrv_name |1*255VCHAR |type of SFP, abbreviated
hardware_rev |1*255VCHAR |hardware version of SFP
vendor_rev |1*255VCHAR |vendor revision of SFP
serial |1*255VCHAR |serial number of the SFP
manufacturer |1*255VCHAR |SFP vendor name
model |1*255VCHAR |SFP model name
Expand Down
2 changes: 1 addition & 1 deletion sonic_platform_base/sonic_xcvr/api/public/sff8436.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def get_transceiver_info(self):
xcvr_info = {
"type": serial_id[consts.ID_FIELD],
"type_abbrv_name": serial_id[consts.ID_ABBRV_FIELD],
"hardware_rev": serial_id[consts.VENDOR_REV_FIELD],
"vendor_rev": serial_id[consts.VENDOR_REV_FIELD],
"serial": serial_id[consts.VENDOR_SERIAL_NO_FIELD],
"manufacturer": serial_id[consts.VENDOR_NAME_FIELD],
"model": serial_id[consts.VENDOR_PART_NO_FIELD],
Expand Down
2 changes: 1 addition & 1 deletion sonic_platform_base/sonic_xcvr/api/public/sff8472.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def get_transceiver_info(self):
xcvr_info = {
"type": serial_id[consts.ID_FIELD],
"type_abbrv_name": serial_id[consts.ID_ABBRV_FIELD],
"hardware_rev": serial_id[consts.VENDOR_REV_FIELD],
"vendor_rev": serial_id[consts.VENDOR_REV_FIELD],
"serial": serial_id[consts.VENDOR_SERIAL_NO_FIELD],
"manufacturer": serial_id[consts.VENDOR_NAME_FIELD],
"model": serial_id[consts.VENDOR_PART_NO_FIELD],
Expand Down
2 changes: 1 addition & 1 deletion sonic_platform_base/sonic_xcvr/api/public/sff8636.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def get_transceiver_info(self):
xcvr_info = {
"type": serial_id[consts.ID_FIELD],
"type_abbrv_name": serial_id[consts.ID_ABBRV_FIELD],
"hardware_rev": serial_id[consts.VENDOR_REV_FIELD],
"vendor_rev": serial_id[consts.VENDOR_REV_FIELD],
"serial": serial_id[consts.VENDOR_SERIAL_NO_FIELD],
"manufacturer": serial_id[consts.VENDOR_NAME_FIELD],
"model": serial_id[consts.VENDOR_PART_NO_FIELD],
Expand Down