[sonic_xcvr] Pre-emphasis settings fails for CMIS devices#231
Closed
aravindmani-1 wants to merge 1 commit intosonic-net:masterfrom
Closed
[sonic_xcvr] Pre-emphasis settings fails for CMIS devices#231aravindmani-1 wants to merge 1 commit intosonic-net:masterfrom
aravindmani-1 wants to merge 1 commit intosonic-net:masterfrom
Conversation
prgeor
approved these changes
Nov 8, 2021
Merged
Contributor
Author
|
Issue is fixed in 400zr initial support #228. . Hence Closing this PR. |
5 tasks
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pre-emphasis settings for CMIS devices is not set as cable length field is not set in xcvrd.
Motivation and Context
Other media types uses "Length Cable Assembly" as cable type. As cable filed is defined in small letters, it failed in xcvrd for CMIS devices.
https://github.com/Azure/sonic-platform-daemons/blob/e5165b79dfe722052ea86694e5fe98429c735e36/sonic-xcvrd/xcvrd/xcvrd.py#L625
How Has This Been Tested?
Tested in DellEMC Z9332f platform.
cable_len_UT.txt
Additional Information (Optional)