changes needed for SNMP docker upgrade to stretch build#23
Merged
jleveque merged 4 commits intosonic-net:masterfrom Mar 22, 2019
Merged
changes needed for SNMP docker upgrade to stretch build#23jleveque merged 4 commits intosonic-net:masterfrom
jleveque merged 4 commits intosonic-net:masterfrom
Conversation
jleveque
suggested changes
Feb 28, 2019
jleveque
suggested changes
Mar 20, 2019
Contributor
jleveque
left a comment
jleveque
left a comment
There was a problem hiding this comment.
Please replace tabs with spaces (2 minimum, more if you want to align them).
Contributor
|
please resolve conflict as well. |
lguohan
approved these changes
Mar 22, 2019
jleveque
approved these changes
Mar 22, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Nazarii Hnydyn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sangita Maity [email protected]
- What I did
I was getting lots of import error during SNMP docker upgrade to stretch build. Made changes accordingly to fix those issues. May be python compatibility issue as by default it is using python3 and there's no exceptions module in python3
- How I did it
Made it compatible with python3 whenever required.
- How to verify it
Use this PR with snmp docker upgrade PR in sonic-buildimage.