Skip to content

Update SFP index definition #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prgeor merged 1 commit into from
Aug 26, 2021
Merged

Update SFP index definition #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions sonic_platform_base/chassis_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,17 +468,18 @@ def get_all_sfps(self):
A list of objects derived from SfpBase representing all sfps
available on this chassis
"""
return self._sfp_list
return [ sfp for sfp in self._sfp_list if sfp is not None ]

def get_sfp(self, index):
"""
Retrieves sfp represented by (0-based) index <index>
Retrieves sfp corresponding to physical port <index>

Args:
index: An integer, the index (0-based) of the sfp to retrieve.
The index should be the sequence of a physical port in a chassis,
starting from 0.
For example, 0 for Ethernet0, 1 for Ethernet4 and so on.
index: An integer (>=0), the index of the sfp to retrieve.
The index should correspond to the physical port in a chassis.
For example:-
1 for Ethernet0, 2 for Ethernet4 and so on for one platform.
0 for Ethernet0, 1 for Ethernet4 and so on for another platform.

Returns:
An object dervied from SfpBase representing the specified sfp
Expand Down