Load policy interval from thermal_policy.json#178
Merged
sujinmkang merged 3 commits intosonic-net:masterfrom Aug 4, 2021
Merged
Load policy interval from thermal_policy.json#178sujinmkang merged 3 commits intosonic-net:masterfrom
sujinmkang merged 3 commits intosonic-net:masterfrom
Conversation
|
|
Contributor
|
@Junchao-Mellanox: Please review. |
Contributor
|
@andywongarista: Please fix new conflicts. |
Contributor
|
@Junchao-Mellanox: Please review. |
1 similar comment
Contributor
|
@Junchao-Mellanox: Please review. |
sujinmkang
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Aug 6, 2021
Description Update thermalctld to retrieve interval from thermal manager (which in turn loads an interval from thermal_policy.json) instead of using a constant. Motivation and Context sonic-net/sonic-platform-common#178 This will allow platform vendors to specify an alternate interval for running thermal policies, e.g. 15 seconds instead of the current 60. How Has This Been Tested? Verified that thermalctld runs without exiting. Also ran test_thermalctld.py
judyjoseph
pushed a commit
that referenced
this pull request
Aug 20, 2021
Description Update ThermalManagerBase to load an interval field from thermal_policy.json if it is available and provide a getter for this interval. Motivation and Context This interval can be used by thermalctld to run policies at an interval specified in thermal_policy.json, rather than a fixed constant (currently 60 seconds). How Has This Been Tested? Verified that thermalctld runs without exiting. Also ran test_thermalctld.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update ThermalManagerBase to load an interval field from thermal_policy.json if it is available and provide a getter for this interval.
Motivation and Context
This interval can be used by thermalctld to run policies at an interval specified in thermal_policy.json, rather than a fixed constant (currently 60 seconds).
How Has This Been Tested?
Verified that thermalctld runs without exiting.
Also ran test_thermalctld.py
Additional Information (Optional)