[sonic_sfp/qsfp_dd.py] Update DOM capability method name to align with other drivers#163
Merged
jleveque merged 1 commit intosonic-net:masterfrom Feb 9, 2021
jleveque:update_dd_dom_cap_name
Merged
[sonic_sfp/qsfp_dd.py] Update DOM capability method name to align with other drivers#163jleveque merged 1 commit intosonic-net:masterfrom jleveque:update_dd_dom_cap_name
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:update_dd_dom_cap_name
Conversation
Contributor
Author
|
@keboliu, @shlomibitton: Please review. |
Contributor
|
@jleveque Need to update the mlnx-platform-api with this change |
Contributor
Author
|
@shlomibitton: Yes, I am aware of this. Another contributor made a similar modification in sonic-net/sonic-mgmt#2937, and I needed to do the same. Since that PR has merged, I believe we should align the method name everywhere. I will make the related changes with the submodule update. If it's OK with with, please approve the changes. |
jleveque
added a commit
that referenced
this pull request
Feb 9, 2021
…h other drivers (#163) Update method name to align with other drivers. Change from `parse_qsfp_dom_capability` to `parse_dom_capability`. Other drivers were aligned via sonic-net/sonic-mgmt#2937. When this submodule is updated in sonic-buildimage, all callers will need to be updated to reflect the new nomenclature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update method name to align with other drivers. Change from
parse_qsfp_dom_capabilitytoparse_dom_capability. Other drivers were aligned via sonic-net/sonic-mgmt#2937.When this submodule is updated in sonic-buildimage, all callers will need to be updated to reflect the new nomenclature.