Thermalctld APIs for recording min and max temp#131
Merged
jleveque merged 3 commits intosonic-net:masterfrom Nov 12, 2020
Merged
Thermalctld APIs for recording min and max temp#131jleveque merged 3 commits intosonic-net:masterfrom
jleveque merged 3 commits intosonic-net:masterfrom
Conversation
Introducing thermal APIs to get min and max temperatures of each sensors - get_minimum_recorded() - get_maximum_recorded() Introducing chassis APIs to check if modular chassis - is_modular_chassis()
mprabhu-nokia
commented
Oct 21, 2020
|
@judyjoseph - could you please review. |
Contributor
|
LGTM |
judyjoseph
approved these changes
Nov 10, 2020
Contributor
|
Please fix conflicts. |
Contributor
Author
|
@jleveque Could you please review this as well? |
jleveque
approved these changes
Nov 12, 2020
Contributor
|
@mprabhu-nokia: Please also add corresponding tests for these APIs to the platform API tests in the sonic-mgmt repo. |
Contributor
Author
Will do. Appreciate quick help with the reviews and merge. |
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
…on (sonic-net#131) Summary: This PR provides replaces the logic to check mux_direction on the y_cable by checking the mux_direction register instead of actively linked and routing TOR register Approach added the changes in y_cable_helper.py by replacing the API What is the motivation for this PR? check_mux_direction is required as per design to replace the active_linked_tor_side active_linked_tor_side -> check_mux_direction check_mux_direction will be utlized as for establishing mux direction explicitly Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sonic-platform-base: Changes to introduce APIs for modular chassis for thermalctld
HLD: sonic-net/SONiC#646
Introducing thermal APIs to get min and max temperatures of each sensors