Always cleanup cEOS mount dir before creating cEOS#9986
Merged
wangxin merged 1 commit intosonic-net:masterfrom Sep 15, 2023
Merged
Always cleanup cEOS mount dir before creating cEOS#9986wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
saiarcot895
approved these changes
Sep 15, 2023
Blueve
approved these changes
Sep 15, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
|
Cherry-pick PR to 202205: #10036 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Collaborator
|
Cherry-pick PR to 202012: #10037 |
Collaborator
|
Cherry-pick PR to 202305: #10038 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors. For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default. However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default. To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Host dir like "/data/ceos/ceos_vms6-1_VM0100" is mounted to cEOS container as flash disk. This dir contains all kinds of configuration files that may affect cEOS behaviors.
For example, older version of cEOS has file ".arista_archive_config" which enables archiving of configs every 1 minute. On newer version of cEOS, this config file is removed by default.
However, after cEOS is upgraded, the left over ".arista_archive_config" file will cause newer cEOS to archive configs every 1 minute by default.
How did you do it?
To ensure that the cEOS container is always "cleanly" started, this change added code to always cleanup the mount dir before creating cEOS.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation