[loganalyzer] Generate dump of log within 1 hour by default if test failed#997
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Jul 10, 2019
wangxin:la-dump
Merged
[loganalyzer] Generate dump of log within 1 hour by default if test failed#997liat-grozovik merged 1 commit intosonic-net:masterfrom wangxin:la-dump
liat-grozovik merged 1 commit intosonic-net:masterfrom
wangxin:la-dump
Conversation
By default the log analyzer generate a dump which collect all the available log files by default in case of failure. This unnecessary and the dump file could be too big. This fix is to generate a dump to collect log within 1 hour by default. If more log is needed, parameter 'dump_since' can be used. Signed-off-by: Xin Wang <[email protected]>
liat-grozovik
approved these changes
Jul 10, 2019
yxieca
pushed a commit
that referenced
this pull request
Jul 10, 2019
…#997) By default the log analyzer generate a dump which collect all the available log files by default in case of failure. This unnecessary and the dump file could be too big. This fix is to generate a dump to collect log within 1 hour by default. If more log is needed, parameter 'dump_since' can be used. Signed-off-by: Xin Wang <[email protected]>
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…per design (sonic-net#997) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Skip last_update_time per design. Fixes # (issue) ADO: 32970571 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Due to recent change in sonic-net/sonic-platform-daemons#604, the last_udpate_time was added. It should be skipped for comparison per design. The `last_update_time` field was added in four place including `post_diagnostic_values_to_db, post_port_dom_flags_to_db, post_port_transceiver_hw_status_flags_to_db, post_port_vdm_thresholds_to_db`. So there are many table involved such as `TRANSCEIVER_STATUS`, `TRANSCEIVER_STATUS_FLAG`. Thus skip in the val comparison. #### How did you do it? Skip the last_update_time for comparison #### How did you verify/test it? E2E #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
By default the log analyzer generate a dump which collects all the
available log files by default in case of failure. This is unnecessary and
the dump file could be too big.
This fix is to generate a dump to collect log within 1 hour by default.
If more log is needed, parameter 'dump_since' can be used.
Type of change
Approach
How did you do it?
Add a new variable 'dump_since' in the loganalyzer_end.yml script. If the variable is not defined, assign default value '1 hour ago' to it. Then value of the variable will be used for the -s argument of the generate_dump command to limit log files to be collected.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation