[Bug fix] port_alias.py enhancement for an index condition judge#990
Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom Jul 16, 2019
keboliu:port_alias_enhance
Merged
[Bug fix] port_alias.py enhancement for an index condition judge#990qiluo-msft merged 3 commits intosonic-net:masterfrom keboliu:port_alias_enhance
qiluo-msft merged 3 commits intosonic-net:masterfrom
keboliu:port_alias_enhance
Conversation
nazariig
reviewed
Jul 4, 2019
liat-grozovik
approved these changes
Jul 15, 2019
qiluo-msft
changed the title
qiluo-msft
reviewed
Jul 15, 2019
qiluo-msft
reviewed
Jul 15, 2019
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Commits: 02dea43 [202012] Add support for BFD notification (sonic-net#990) 337fd97 Change sonic-buildimage.vs artifact source from CI build to official build. (sonic-net#992) 490f442 Support for cisco-8000 platform for sonic-sairedis/syncd (sonic-net#823)
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: t1-f2-d10u8 topo has a downstream T0 neighbor with IP 10.0.0.1, which conflicts with default dst_ip_addr in this test. We should randomly choose an upstream VM IP instead, like t1-isolated-* topos. Manually cherry-picked from sonic-net#22115 Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [x] 202503 - [x] 202511 ### Approach #### What is the motivation for this PR? test_stress_acl.py failed on t1-f2-d10u8 topo #### How did you do it? Randomly choose an upstream VM IP instead, like t1-isolated-* topos #### How did you verify/test it? test_stress_acl.py passed on t1-f2-d10u8 topo #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: markxiao <markxiao@arista.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Add an index condition check to make sure the index will not out of range.
How did you verify/test it?
run generate minigraph command
Any platform specific information?
No
Supported testbed topology if it's a new test case?
support all topo
Documentation