Skip to content

Add portstat to debug FDB packet delay issue#9807

Closed
kperumalbfn wants to merge 5 commits intosonic-net:masterfrom
kperumalbfn:kperumal/fdb_delay
Closed

Add portstat to debug FDB packet delay issue#9807
kperumalbfn wants to merge 5 commits intosonic-net:masterfrom
kperumalbfn:kperumal/fdb_delay

Conversation

@kperumalbfn
Copy link
Collaborator

Description of PR

In some fdb test runs, packets are not received by PTF server. To debug this issue, add DUT's portstat in the test log.

Type of change

Debug failures

Back port request

None

Approach

What is the motivation for this PR?

Add DUT portstat to debug any PTF server packet drop issues.

How did you do it?

Include DUT's portstat.

@kperumalbfn kperumalbfn requested a review from jcaiMR as a code owner September 1, 2023 19:26
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 1, 2023

CLA Missing ID CLA Not Signed

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/fdb/test_fdb.py:195:121: E501 line too long (121 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@kperumalbfn kperumalbfn closed this Sep 1, 2023
@kperumalbfn kperumalbfn deleted the kperumal/fdb_delay branch September 1, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants