RCA is When we are deleting the agent-id, hsflowd is referring to eth0#9766
Conversation
…e eth0 interface and expecting samples in that interface. (This is with the updated hsflowd , When you start hsflowd with no explicit agent-id configured, it will run an "election" to decide which IP address to adopt.) Signed-off-by: Gokulnath-Raja <[email protected]> Co-authored-by: mohanapriya-meganathan <[email protected]>
| partial_ptf_runner( | ||
| polling_int=20, | ||
| agent_id=var['lo_ip'], | ||
| agent_id=var['mgmt_ip'], |
There was a problem hiding this comment.
This is a change of behavior. Is this documented in the hsflowd release notes?
There was a problem hiding this comment.
As per this commit , When dynamic agent or agentIP override is removed, revert to automati… · sflow/host-sflow@7cb2b83 (github.com) and as per the discussion sflow/host-sflow#49 (comment) , whenever the agent-id is removed, agent IP address chosen should be unique persistent and reachable and it can reach to the collector IP. Currently when we are executing this script we got this below error,
After upgrading to 2.0.41, when the agent-id is deleted, it is expecting the management ip is the next preferred elected address to reach to the collector as per this script. So, we modified as per the behavior.
Attached the failed logs for more information.
test_sflow.log
There was a problem hiding this comment.
Looks like a hsflowd behavioral change. As long as it is documented, I am fine. @prsunny @padmanarayana FYI
|
I see the test failed after this PR is merged. opened a issue: #10291 |
…e eth0 interface and expecting samples in that interface. (sonic-net#9766) (This is with the updated hsflowd , When you start hsflowd with no explicit agent-id configured, it will run an "election" to decide which IP address to adopt.)
|
Cherry-pick PR to 202305: #10446 |
…e eth0 interface and expecting samples in that interface. (#9766) (This is with the updated hsflowd , When you start hsflowd with no explicit agent-id configured, it will run an "election" to decide which IP address to adopt.)
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
…e eth0 interface and expecting samples in that interface. (sonic-net#9766) (This is with the updated hsflowd , When you start hsflowd with no explicit agent-id configured, it will run an "election" to decide which IP address to adopt.)
7 participants
Why I did it
For sflow_bug#13407: After migration of hsflowd version v2.0.51-26, When we are deleting the agent-id, hsflowd is referring for the eth0 interface and expecting samples in that interface.
(This is with the updated hsflowd , When you start hsflowd with no explicit agent-id configured, it will run an "election" to decide which IP address to adopt.)
How I did it
Modified the script to check for mgmt_ip.
How to verify it
Post upgrade to latest version of hsflowd, run the script and make sure that it passes.
Signed-off-by: Gokulnath-Raja [email protected]
Co-authored-by: mohanapriya-meganathan [email protected]
Back port request
Script Log
test_sflow_log.txt