Skip to content

[202012][Snappi] PFCWD Tolerance Fixes (#9567) #9749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 1 commit into from
Aug 30, 2023
Merged

[202012][Snappi] PFCWD Tolerance Fixes (#9567) #9749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/snappi_tests/pfcwd/files/pfcwd_basic_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
WARM_UP_TRAFFIC_DUR = 1
DATA_PKT_SIZE = 1024
SNAPPI_POLL_DELAY_SEC = 2
DEVIATION = 0.25
DEVIATION = 0.3

def run_pfcwd_basic_test(api,
testbed_config,
Expand Down Expand Up @@ -57,6 +57,9 @@ def run_pfcwd_basic_test(api,
start_pfcwd(duthost)
enable_packet_aging(duthost)

# Set appropriate pfcwd loss deviation - these values are based on empirical testing
DEVIATION = 0.35 if duthost.facts['asic_type'] in ["broadcom"] else 0.3

""" Get the ID of the port to test """
port_id = get_dut_port_id(dut_hostname=duthost.hostname,
dut_port=dut_port,
Expand Down
25 changes: 15 additions & 10 deletions tests/snappi_tests/pfcwd/files/pfcwd_multi_node_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def run_pfcwd_multi_node_test(api,

""" Retrieve ASIC information for DUT """
asic_type = duthost.facts['asic_type']
rx_tx_tol_thrhlds = [0.0001, 0.0002] # Maintain a 0.01% and 0.02% deviation between tx and rx frames

__verify_results(rows=flow_stats,
speed_gbps=speed_gbps,
Expand All @@ -141,7 +142,8 @@ def run_pfcwd_multi_node_test(api,
data_pkt_size=DATA_PKT_SIZE,
trigger_pfcwd=trigger_pfcwd,
pause_port_id=port_id,
tolerance=TOLERANCE_THRESHOLD,
rx_deviation=TOLERANCE_THRESHOLD,
rx_tx_deviations=rx_tx_tol_thrhlds,
asic_type=asic_type)


Expand Down Expand Up @@ -556,7 +558,8 @@ def __verify_results(rows,
data_pkt_size,
trigger_pfcwd,
pause_port_id,
tolerance,
rx_deviation,
rx_tx_deviations,
asic_type):
"""
Verify if we get expected experiment results
Expand All @@ -573,7 +576,8 @@ def __verify_results(rows,
test_flow_pause (bool): if test flows are expected to be paused
trigger_pfcwd (bool): if PFC watchdog is expected to be triggered
pause_port_id (int): ID of the port to send PFC pause frames
tolerance (float): maximum allowable deviation
rx_deviation (float): maximum allowable deviation for rx_frames relative to theoretical value
rx_tx_deviations (list of floats): maximum allowable % deviation for rx_frames relative to tx_frames
asic_type (str): asic_type information for DUT

Returns:
Expand Down Expand Up @@ -601,8 +605,8 @@ def __verify_results(rows,
exp_bg_flow_rx_pkts = bg_flow_rate_percent / 100.0 * speed_gbps \
* 1e9 * data_flow_dur_sec / 8.0 / data_pkt_size
deviation = (rx_frames - exp_bg_flow_rx_pkts) / float(exp_bg_flow_rx_pkts)
pytest_assert(abs(deviation) < tolerance,
'{} should receive {} packets (actual {})'.\
pytest_assert(abs(deviation) < rx_deviation,
'{} should receive {} packets (actual {})'.
format(flow_name, exp_bg_flow_rx_pkts, rx_frames))

elif test_flow_name in flow_name:
Expand Down Expand Up @@ -633,11 +637,12 @@ def __verify_results(rows,
format(flow_name, exp_test_flow_rx_pkts, rx_frames))

else:
""" Otherwise, the test flow is not impacted by PFC storm """
pytest_assert(tx_frames == rx_frames,
'{} should not have any dropped packet'.format(flow_name))
for dev_pct in rx_tx_deviations:
""" Otherwise, the test flow is not impacted by PFC storm """
pytest_assert(abs(tx_frames - rx_frames)/float(tx_frames) < dev_pct,
'{} should be within {} percent deviation'.format(flow_name, dev_pct*100))

deviation = (rx_frames - exp_test_flow_rx_pkts) / float(exp_test_flow_rx_pkts)
pytest_assert(abs(deviation) < tolerance,
'{} should receive {} packets (actual {})'.\
pytest_assert(abs(deviation) < rx_deviation,
'{} should receive {} packets (actual {})'.
format(flow_name, exp_test_flow_rx_pkts, rx_frames))