[action] [PR:8222] Improvising qos tests by tunning the qos params for single_asic, single_dut_multi_asic and multi_dut#9703
Merged
wangxin merged 1 commit intosonic-net:202305from Aug 29, 2023
Conversation
…le_dut_multi_asic and multi_dut (sonic-net#8222) * QoS tunning for LossyQueueTest * Making assert specific to dnx for DscpQueueMapping qos_test fix flake8 errors flake8 issue resolved * Recommiting the changes of qos.yml to qos_params_j2c.yml * Reverting dscp to 7 as this is fixed in BRCM CSP * Revert "Making assert specific to dnx for DscpQueueMapping qos_test" This reverts commit dcbf90fa1bbdb3778d9ef86a202c30d86bd08114. * changing dscp value back to 8 * tx_enable/disable retry check corrected * Flake8 errore fixed * Making check to run only for chassis in LossyQueue * Adding check for sai_base for tx_enable/disable
6 tasks
Collaborator
Author
|
Original PR: #8222 |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
This PR is in continuation of PR# #8149
which was originally part of PR# #6946
The existing QoS (test_qos_sai.py) is written to accommodate a single asic on a single Dut. But, we require the same tests to be executed against a T2 chassis (with single/multi-asic linecards) and multi-asic pizza boxes.
Summary:
This PR is in continuation to above PR's mentioned
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
1.Qos test cases failed with intermittent errors
How did you do it?
Two issues are addressed here :
1.The dscp queue mapping for LossyQueue Test changed in config file to map to queue 1 of traffic-class instead of 0 since disabling the tx and filling up the queue 0 prevents the lacp packets going out and port channel goes down
2.During Qos test on transmission disable and enable, sometimes on test failure the port dangles in a transmission disable state and did not recover. Switching the step to enable the transmission port before the BCMSAI credit-watchdog enable , eradicate the test failure due to bad port state.
How did you verify/test it?
Executed qos testcases on for single_asic ,single_dut_multi_asic & multi_dut
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation