[action] [PR:6487] Remove bypass on duplicate lanes' platforms for GCU tests#9702
Merged
mssonicbld merged 1 commit intosonic-net:202205from Aug 28, 2023
Merged
Conversation
Summary: Duplicate lane check was added in sonic-utilities. Remove that in sonic-mgmt. What is the motivation for this PR? The GCU-related tests were bypassed in duplicate lanes' platforms. We don't want to skip GCU tests on such platforms. So we update the unique lane check and simply bypass the check for such platforms in GCU feature. Now the GCU tests can be tested on such platforms. How did you do it? Fix in GCU feature. sonic-net/sonic-utilities#2343 has been updated to sonic-buildimage. How did you verify/test it? Run e2e test in specific platform.
6 tasks
Collaborator
Author
|
Original PR: #6487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Duplicate lane check was added in sonic-utilities. Remove that in sonic-mgmt.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The GCU-related tests were bypassed in duplicate lanes' platforms. We don't want to skip GCU tests on such platforms.
So we update the unique lane check and simply bypass the check for such platforms in GCU feature.
Now the GCU tests can be tested on such platforms.
How did you do it?
Fix in GCU feature.
sonic-net/sonic-utilities#2343 has been updated to sonic-buildimage.
How did you verify/test it?
Run e2e test in specific platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation