[action] [PR:9567] [Snappi] PFCWD Tolerance Fixes#9697
Merged
mssonicbld merged 1 commit intosonic-net:202305from Aug 28, 2023
Merged
[action] [PR:9567] [Snappi] PFCWD Tolerance Fixes#9697mssonicbld merged 1 commit intosonic-net:202305from
mssonicbld merged 1 commit intosonic-net:202305from
Conversation
b0af55d to
4e6f83f
Compare
6 tasks
Collaborator
Author
|
Original PR: #9567 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: PFCWD tests deviations for certain basic and multi node tests did not exist since there was no source of empirical data available for devices until recently. These tests require empirical tuning for the specific device the test runs on. This PR introduces certain allowable deviations based on device type for basic and multi node PFCWD tests.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix PFCWD snappi tests running on nightly
How did you do it?
Introduce new acceptable tolerances
How did you verify/test it?
Ran on lab device
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation