[TACACS] Retry reboot in ro-disk UT when DUT not reachable.#9639
Merged
liuh-80 merged 2 commits intosonic-net:masterfrom Aug 30, 2023
Merged
[TACACS] Retry reboot in ro-disk UT when DUT not reachable.#9639liuh-80 merged 2 commits intosonic-net:masterfrom
liuh-80 merged 2 commits intosonic-net:masterfrom
Conversation
qiluo-msft
reviewed
Aug 29, 2023
tests/tacacs/test_ro_disk.py
Outdated
| except AnsibleConnectionFailure as e: | ||
| logger.error("DUT not reachable, exception: {} attempt:{}/{}". | ||
| format(repr(e), i, retries)) | ||
| wait(wait_time, msg="Wait {} seconds before retry.".format(wait_time)) |
Contributor
qiluo-msft
approved these changes
Aug 30, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
…t#9639) Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
…t#9639) Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
|
Cherry-pick PR to 202012: #10023 |
Collaborator
|
Cherry-pick PR to 202305: #10024 |
Collaborator
|
Cherry-pick PR to 202205: #10025 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 15, 2023
…t#9639) Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This was referenced Sep 15, 2023
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202012 branch
Created PR to 202305 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Sep 15, 2023
Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…t#9639) Retry reboot in ro-disk UT when DUT not reachable. ### Description of PR Retry reboot in ro-disk UT when DUT not reachable. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request - [ ] 201911 - [ ] 202012 - [x] 202205 ### Approach #### What is the motivation for this PR? Device unreachable after TACACS ro-disk UT failed. #### How did you do it? Add retry when ro-disk DUT not reachable before reboot. #### How did you verify/test it? Pass all UT #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry reboot in ro-disk UT when DUT not reachable.
Work item tracking
Description of PR
Retry reboot in ro-disk UT when DUT not reachable.
Type of change
Back port request
Approach
What is the motivation for this PR?
Device unreachable after TACACS ro-disk UT failed.
How did you do it?
Add retry when ro-disk DUT not reachable before reboot.
How did you verify/test it?
Pass all UT
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation