[Mellanox] Update QoS test cases for SN5600 #9583
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Sep 27, 2023
Merged
[Mellanox] Update QoS test cases for SN5600 #9583liat-grozovik merged 2 commits intosonic-net:masterfrom
liat-grozovik merged 2 commits intosonic-net:masterfrom
Conversation
For spc4, because HBA is enabled, we need to use new formula to calculate the shared buffer size for pg and q. Change-Id: I61d2d2c0f5150f6227c15aa29a77747836356001
stephenxs
approved these changes
Aug 22, 2023
JibinBao
changed the title
JibinBao
changed the title
JibinBao
changed the title
Contributor
Author
|
@bingwang-ms @XuChen-MSFT Can you help review it? |
…sic_type To improve the extensibility, add one mechanism to handle special QoS parameters for the specified asic_type Change-Id: I69086ce5858669472f634b1bcd9a5b436650d54e
Contributor
Author
|
@bingwang-ms @XuChen-MSFT Can you help review it? |
Contributor
Author
|
@bingwang-ms Can you help review this PR? |
nhe-NV
approved these changes
Sep 27, 2023
bingwang-ms
approved these changes
Sep 27, 2023
Collaborator
We don't have SN5600 testbed, so I have no way to verify the change on a physical testbed. The change looks good to me. |
liat-grozovik
approved these changes
Sep 27, 2023
liat-grozovik
changed the title
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 24, 2023
For Nvidia SN5600 the formula to calculate the shared buffer size for pg and queue differs from other Spectrum. So, update the corresponding code for it.
Collaborator
|
Cherry-pick PR to 202305: #10442 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 25, 2023
For Nvidia SN5600 the formula to calculate the shared buffer size for pg and queue differs from other Spectrum. So, update the corresponding code for it.
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
For Nvidia SN5600 the formula to calculate the shared buffer size for pg and queue differs from other Spectrum. So, update the corresponding code for it.
JibinBao
added a commit
to JibinBao/sonic-mgmt
that referenced
this pull request
Aug 30, 2024
1. update qos sai test for sn5400 according to the two PRs below a. sonic-net#9583 b. sonic-net#12848 2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4 Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
8 tasks
bingwang-ms
pushed a commit
that referenced
this pull request
Oct 30, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Oct 30, 2024
1. update qos sai test for sn5400 according to the two PRs below a. sonic-net#9583 b. sonic-net#12848 2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4 Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 31, 2024
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
1. update qos sai test for sn5400 according to the two PRs below a. sonic-net#9583 b. sonic-net#12848 2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4 Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
1. update qos sai test for sn5400 according to the two PRs below a. sonic-net#9583 b. sonic-net#12848 2. To stabilize testQosSaiQSharedWatermark[single_asic-wm_q_shared_lossy], update margin from 4 to 5 for spc4 Change-Id: Ic3919a9123cd968fb9d89013687cf31791684208
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
For Nvidia SN5600 the formula to calculate the shared buffer size for pg and queue differs from other Spectrum. So, update the corresponding code for it.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Update QoS cases for SN5600
How did you do it?
Update the code according to the relevant formula
How did you verify/test it?
Run qos tests on the SN5600 device
Any platform specific information?
SN5600
Supported testbed topology if it's a new test case?
Any
Documentation