[PTF python3 migration] Modify test_advanced_reboot PTF script#9550
Merged
wsycqyz merged 15 commits intosonic-net:masterfrom Sep 3, 2023
Merged
[PTF python3 migration] Modify test_advanced_reboot PTF script#9550wsycqyz merged 15 commits intosonic-net:masterfrom
wsycqyz merged 15 commits intosonic-net:masterfrom
Conversation
vaibhavhd
reviewed
Aug 18, 2023
| module_ignore_errors=self.moduleIgnoreErrors, | ||
| timeout=REBOOT_CASE_TIMEOUT | ||
| timeout=REBOOT_CASE_TIMEOUT, | ||
| is_python3=True |
Contributor
There was a problem hiding this comment.
Where is this is_python3 argument being used?
Contributor
Author
There was a problem hiding this comment.
In ptf_runner.py, if is_python3==true, Python3 is used to run the PTF script.
vaibhavhd
previously approved these changes
Aug 18, 2023
Contributor
vaibhavhd
left a comment
vaibhavhd
left a comment
There was a problem hiding this comment.
LGTM, please ensure that the testing is also done on physical DUT, as the KVM test do not cover all the test conditions.
Contributor
Author
Understood. |
wangxin
previously approved these changes
Aug 29, 2023
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
previously approved these changes
Sep 1, 2023
vaibhavhd
approved these changes
Sep 1, 2023
| self.check_param('arista_vms', [], required=True) | ||
| self.check_param('min_bgp_gr_timeout', 15, required=False) | ||
| self.check_param('warm_up_timeout_secs', 300, required=False) | ||
| self.check_param('warm_up_timeout_secs', 600, required=False) |
Contributor
There was a problem hiding this comment.
Why is this change needed?
Contributor
Author
There was a problem hiding this comment.
This is part of old commit. Final version didn't have this change.
Collaborator
|
@wsycqyz PR conflicts with 202305 branch |
wsycqyz
added a commit
to wsycqyz/sonic-mgmt
that referenced
this pull request
Sep 4, 2023
…-net#9550) Summary: Migrate test_advanced_reboot's PTF script to Python3 What is the motivation for this PR? This is part of Python3 migration project. This PR migrate test_advanced_reboot's PTF script to Python3. How did you do it? 2to3 and manually code change How did you verify/test it? Test with KVM testbed, physical testbed 3800 and PR test.
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Sep 5, 2023
#9550) (#9819) Manually cherry-pick PR #9550 Summary: Migrate test_advanced_reboot's PTF script to Python3 What is the motivation for this PR? This is part of Python3 migration project. This PR migrate test_advanced_reboot's PTF script to Python3. How did you do it? 2to3 and manually code change How did you verify/test it? Test with KVM testbed, physical testbed 3800 and PR test.
yxieca
pushed a commit
that referenced
this pull request
Sep 8, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…-net#9550) Summary: Migrate test_advanced_reboot's PTF script to Python3 What is the motivation for this PR? This is part of Python3 migration project. This PR migrate test_advanced_reboot's PTF script to Python3. How did you do it? 2to3 and manually code change How did you verify/test it? Test with KVM testbed, physical testbed 3800 and PR test.
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
sonic-net#9550)" (sonic-net#9867) This reverts commit fe0d44d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Migrate test_arpall PTF script to Python3
Type of change
Back port request
Approach
What is the motivation for this PR?
This is part of Python3 migration project.
This PR migrate test_arpall PTF script to Python3.
How did you do it?
2to3 and manually code change
How did you verify/test it?
Test with KVM testbed, physical testbed 3800 and PR test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation