[lag2] enhance lag2-minlink test (smart timeout)#950
Merged
stcheng merged 2 commits intosonic-net:masterfrom Aug 27, 2019
Merged
[lag2] enhance lag2-minlink test (smart timeout)#950stcheng merged 2 commits intosonic-net:masterfrom
stcheng merged 2 commits intosonic-net:masterfrom
Conversation
Change-Id: I165d6ae8bc5ab2100b9d26c1d8c7ad02f0252cd8 Signed-off-by: Mykola Faryma <[email protected]>
liat-grozovik
approved these changes
Jul 1, 2019
stepanblyschak
approved these changes
Jul 1, 2019
liat-grozovik
requested changes
Jul 8, 2019
Collaborator
There was a problem hiding this comment.
@mykolaf please have the option to get the value of the max value for timeout as a parameter from the user while the default should be kept as it was before.
the improvement is good as well.
stcheng
reviewed
Jul 9, 2019
|
|
||
| - name: Set retries | ||
| set_fact: | ||
| retries: "{{ (wait_down_time / delay | float) | round(0, 'ceil') }}" |
Contributor
There was a problem hiding this comment.
could you combine the set_fact steps into one?
Contributor
Author
There was a problem hiding this comment.
No, the variables depend on each other. In this case we would get an undefined var error
Change-Id: Ia0331f6cb78accbbb7019f30ec8b98f371cd8d98 Signed-off-by: Mykola Faryma <[email protected]>
mykolaf
changed the title
stcheng
approved these changes
Aug 27, 2019
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
…-net#950) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR adjust test_techsupport.py to support IPv6 * fixed mirroring fixture when ipv6 only topo is used * verified cmd to check is supported with new topo Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? testing ipv6 only topology #### How did you do it? Adjusted the test to handle this topology, #### How did you verify/test it? internal regression #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I165d6ae8bc5ab2100b9d26c1d8c7ad02f0252cd8
Signed-off-by: Mykola Faryma [email protected]
Description of PR
Summary:
Remove unnecessary pauses, add periodic polling for expected state
Fixes # (issue) Lag minlink failing after recent changes to teamd.
Type of change
Approach
Remove unnecessary pauses, add periodic polling for expected state. Reduce overall test duration (50m ->30m for t1-lag), added option for user to specify the maximum waiting time via
wait_timeoutvariable.How did you do it?
Introduce deselect_time variable, representing time in which the lag member is expected to be deselected ( otherwise we would exit on first poll, and fail "verify lag member deselected" check.
The polling is done with as simple one-liner every 5s, allowing to proceed with the "verify" tasks as soon as the condition is met.
How did you verify/test it?
Run lag-minlink test on t1-lag & t0.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation