[bfn] Added Barefoot GRE protocol type support for everflow_testbed TC#949
Merged
lguohan merged 2 commits intosonic-net:masterfrom Mar 19, 2020
Merged
[bfn] Added Barefoot GRE protocol type support for everflow_testbed TC#949lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
NStetskovych-zz
approved these changes
Jun 14, 2019
Contributor
Author
msosyak
approved these changes
Aug 6, 2019
Signed-off-by: Andriy Kokhan <akokhan@barefootnetworks.com>
akokhan
force-pushed
the
bfn-everflow-testbed
branch
from
12bd4e1 to
f7ad81e
Compare
akokhan
force-pushed
the
bfn-everflow-testbed
branch
from
f7ad81e to
a6a478c
Compare
Contributor
Author
|
@lguohan please review |
Contributor
Author
|
@lguohan please take a look. Thank you. |
prsunny
approved these changes
Feb 14, 2020
daall
approved these changes
Feb 26, 2020
fraserg-arista
pushed a commit
to fraserg-arista/sonic-mgmt
that referenced
this pull request
Feb 24, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- This PR refactors and increases the scope to include more BGP IPv6 route convergence checks and BGP scale tests, primarily for better flexibility and maintainability to further include a BGP Admin flap test PR to follow. --> Summary: - Groups interface and BGP session shutdown/startup actions, along with scope to include more connection tests into generalized methods for more extensibility and reduced code duplication. - Introduces parameters such as `shutdown_connections`, `connection_type`, and `shutdown_all_connections` - Adds new helper methods for command execution and BGP session flapping in both Ansible library and test scripts. - Refactors the main convergence and port-flapping logic with error handling and modularity. - Replaces previous hardcoded port shutdown/restoration patterns with parameter-driven logic. - Adds support for flapping 'all' ports, generalizing session/connection-based operations, and improves logging for better debugging. - Removes the old `test_device_unisolation` test and integrates its scenario into new parameterized tests for full coverage. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ x ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Motivated by the need for refactoring, and code maintainability in BGP IPv6 route convergence testing. These changes make it easier to extend as new test requirements arise, primarily as of now for BGP Admin flapping. #### How did you do it? - Refactored Ansible module (`ansible/library/check_bgp_ipv6_routes_converged.py`) to handle generic connection shutdown and startup actions. - Updated the test suite (`tests/bgp/test_ipv6_bgp_scale.py`) to include new parameters, helper utilities, and support for BGP session and port-wide scaling. #### How did you verify/test it? Ran the tests on t0-isolated-d2u510s2 topology on broadcom Arista-7060X6-64PE-B-C512S2 #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-swss: * 67f7191 2019-06-20 | Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945) (HEAD -> 201803, origin/201803) [Renuka Manavalan] * 2cae61b 2019-07-07 | Fix: crash while destructing crmorch (sonic-net#731) (sonic-net#949) [Renuka Manavalan] sonic-swss-common: * 58b1930 2019-07-07 | Add an assert to logger, which will log a message and abort. (sonic-net#286) (sonic-net#287) (HEAD -> 201803, origin/201803) [Renuka Manavalan]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Kokhan akokhan@barefootnetworks.com
Description of PR
Added Barefoot GRE protocol type support for everflow_testbed TC
Type of change
Approach
How did you do it?
How did you verify/test it?
Run everflow_testbed TC on BFN target
Any platform specific information?