[master][CI/CD] Priority use args.scripts to get test modules#9480
Merged
lerry-lee merged 3 commits intosonic-net:masterfrom Aug 21, 2023
Merged
Conversation
Signed-off-by: Chun'ang Li <[email protected]>
Signed-off-by: Chun'ang Li <[email protected]>
yejianquan
reviewed
Aug 17, 2023
Signed-off-by: Chun'ang Li <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…net#9480) What is the motivation for this PR? Priority use args.scripts to get test modules if this param is not None for KVM platform. Because pr_test_scripts.yaml is the default file to get test modules, If we don't pass args.scripts, it will get test module from pr_test_scripts.yaml. How did you do it? Modify test_plan.py. How did you verify/test it? Manually trigger two test plans, one pass args.scrips, it will get test module from it, another don't pass args.scripts, it will get test module from pr_test_scripts.yaml. All as expected. Signed-off-by: Chun'ang Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Priority use
args.scriptsto get test modules if this param is not None for KVM platform. Becausepr_test_scripts.yamlis the default file to get test modules, If we don't passargs.scripts, it will get test module frompr_test_scripts.yaml.Signed-off-by: Chun'ang Li [email protected]
Type of change
Back port request
Approach
What is the motivation for this PR?
Priority use
args.scriptsto get test modules if this param is not None for KVM platform. Becausepr_test_scripts.yamlis the default file to get test modules, If we don't passargs.scripts, it will get test module frompr_test_scripts.yaml.How did you do it?
Modify test_plan.py.
How did you verify/test it?
Manually trigger two test plans, one pass
args.scrips, it will get test module from it, another don't passargs.scripts, it will get test module frompr_test_scripts.yaml. All as expected.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation