[action] [PR:9453] [Fix] Fix multi-asic flaky lldp not ready issue#9476
Merged
yejianquan merged 1 commit intosonic-net:202305from Aug 16, 2023
Merged
[action] [PR:9453] [Fix] Fix multi-asic flaky lldp not ready issue#9476yejianquan merged 1 commit intosonic-net:202305from
yejianquan merged 1 commit intosonic-net:202305from
Conversation
Description of PR In the recover of sanity check, for config_reload, we simply sleep 120s. In some topology, like multi-asic scenario, it's not enough. lldp services get a big chance that not ready after 120s, then sanity failed. Use config_reload with safe_reload to better handle this flaky issue. Approach What is the motivation for this PR? Fix multi-asic lldp flaky issue. How did you do it? Use config_reload with safe_reload to better handle this flaky issue. co-authorized by: [email protected]
6 tasks
Collaborator
Author
|
Original PR: #9453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
In the recover of sanity check, for config_reload, we simply sleep 120s.
In some topology, like multi-asic scenario, it's not enough.
lldp services get a big chance that not ready after 120s, then sanity failed.
Use config_reload with safe_reload to better handle this flaky issue.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix multi-asic lldp flaky issue.
How did you do it?
Use config_reload with safe_reload to better handle this flaky issue.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation